[pve-devel] [PATCH manager v2] fix: make 'ceph-volume' conditional on quincy install

[pve-devel] [PATCH manager v2] fix: make 'ceph-volume' conditional on quincy install

[Stefan Sterz]

when installing non-quincy versions, 'ceph-volume' is not contained in
the respective repositories and, thus, the install process would fail.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
---
tested this by installing octopus, pacific and quincy. same issues as
before.

 PVE/CLI/pveceph.pm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm
index a85df130..5c21bf7e 100755
--- a/PVE/CLI/pveceph.pm
+++ b/PVE/CLI/pveceph.pm
@@ -176,13 +176,17 @@ __PACKAGE__->register_method ({
 	my @ceph_packages = qw(
 	    ceph
 	    ceph-common
-	    ceph-volume
 	    ceph-mds
 	    ceph-fuse
 	    gdisk
 	    nvme-cli
 	);
 
+	# when installing versions older than quincy, 'ceph-volume' does not exists. don't include it
+	if ($cephver ne 'octopus' and $cephver ne 'pacific') {
+	    push @ceph_packages, 'ceph-volume';
+	}
+
 	print "start installation\n";
 
 	# this flag helps to determine when apt is actually done installing (vs. partial extracing)
-- 
2.30.2

[pve-devel] applied: Re: [PATCH manager v2] fix: make 'ceph-volume' conditional on quincy install

[Thomas Lamprecht]

On 04/07/2022 17:45, Stefan Sterz wrote:
> when installing non-quincy versions, 'ceph-volume' is not contained in
> the respective repositories and, thus, the install process would fail.
> 
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> tested this by installing octopus, pacific and quincy. same issues as
> before.
> 
>  PVE/CLI/pveceph.pm | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
>

applied, thanks! reworded the commit subject a bit and in a followup commit
also the comment to make it clearer when we can drop support for that.

FWIW, the thought on forward compatibility is a good one, but often we either
translate the code names to versions so that we can do a easier to understand,
and often also a bit more robust

`$ver_map->{$cephver} >= $ver_map->{quincy}`

But I don't expect much change here until we can just remove it with 8.0, where
we probably don't support new pacific installations anyway, so your variant is
just fine here.