From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH access-control 1/2] roles: restrict Permissions.Modify to Administrator
Date: Wed, 7 Jun 2023 11:18:20 +0200 [thread overview]
Message-ID: <dd14d4b6-89a0-f8a5-517e-6f5952a3b83b@proxmox.com> (raw)
In-Reply-To: <20230605142137.854891-1-f.gruenbichler@proxmox.com>
Am 05/06/2023 um 16:21 schrieb Fabian Grünbichler:
> to reduce the chances of accidentally handing out privilege modification
> privileges. the old default setup of having Permissions.Modify in PVESysAdmin
> and PVEAdmin weakened the distinction between those roles and Administrator.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>
> Notes:
> this is obviously a breaking change
>
> can be detected in pve7to8 if any ACLs with PVESysAdmin or PVEAdmin are
> configured, with a hint about adding a custom role if desired.
>
> src/PVE/AccessControl.pm | 5 +++--
> src/test/perm-test1.pl | 4 ++++
> src/test/perm-test8.pl | 4 ++--
> src/test/test1.cfg | 2 ++
> src/test/test8.cfg | 2 +-
> 5 files changed, 12 insertions(+), 5 deletions(-)
>
>
applied both patches, thanks!
prev parent reply other threads:[~2023-06-07 9:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 14:21 [pve-devel] " Fabian Grünbichler
2023-06-05 14:21 ` [pve-devel] [PATCH access-control 2/2] acls: restrict less-privileged ACL modifications Fabian Grünbichler
2023-06-07 9:18 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd14d4b6-89a0-f8a5-517e-6f5952a3b83b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal