From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dietmar Maurer <dietmar@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-xtermjs v3] termproxy: allow to use unix sockets for auth requests
Date: Thu, 25 Jul 2024 18:21:47 +0200 [thread overview]
Message-ID: <dd11f586-cdfd-4f12-84da-67134ff86082@proxmox.com> (raw)
In-Reply-To: <20240724113329.175907-1-dietmar@proxmox.com>
On 24/07/2024 13:33, Dietmar Maurer wrote:
> Remove ureq, because it does not support unix sockets.
>
> Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
> ---
>
> Changes sinve v2:
> split out the command line help text change into patch:
> [PATCH pve-xtermjs] termproxy: fix the command line help text
>
> Changes since v1:
>
> - use extra --authsocket cli option
FYI: I renamed this and the pre-existing --authport option to --auth-socket and
--auth-port, respectively, with the latter getting a fallback to the old variant
for backward compat.
And yeah I know that this in borderline useless as it's just an internal tool,
but I got a few spare minutes in the train where starting something more involved
was not justified, and making this consistent with the `--port-as-fd` option
and our modern CLI option style in general felt like an OK clean-up to do.
Anyhow, now bumped and uploaded as proxmox-termproxy in version 1.1.0.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-07-25 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 11:33 Dietmar Maurer
2024-07-25 8:59 ` [pve-devel] applied: " Wolfgang Bumiller
2024-07-25 16:21 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd11f586-cdfd-4f12-84da-67134ff86082@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.