[pve-devel] [PATCH v2 manager] ui: lvm: expose saferemove setting

[pve-devel] [PATCH v2 manager] ui: lvm: expose saferemove setting

[Fiona Ebner]

It can be security-relevant in some environments. The LVM storage
documentation can be reached via the "Help" button and contains a few
more details.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

Changes in v2:
    * Improve label text (thanks to Fabian!)

 www/manager6/storage/LVMEdit.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
index b5a2d812..882b9eb7 100644
--- a/www/manager6/storage/LVMEdit.js
+++ b/www/manager6/storage/LVMEdit.js
@@ -232,5 +232,11 @@ Ext.define('PVE.storage.LVMInputPanel', {
 		'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'),
 	    },
 	},
+	{
+	    xtype: 'proxmoxcheckbox',
+	    name: 'saferemove',
+	    uncheckedValue: 0,
+	    fieldLabel: gettext('Wipe Removed Volumes'),
+	},
     ],
 });
-- 
2.39.2

[pve-devel] [PATCH v2 docs] storage: lvm: mention how saferemove setting is called in the UI

[Fiona Ebner]

to avoid confusion.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

New in v2.

 pve-storage-lvm.adoc | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/pve-storage-lvm.adoc b/pve-storage-lvm.adoc
index cff5d3e..487aac6 100644
--- a/pve-storage-lvm.adoc
+++ b/pve-storage-lvm.adoc
@@ -37,11 +37,11 @@ on a remote iSCSI server.
 
 `saferemove`::
 
-Zero-out data when removing LVs. When removing a volume, this makes
-sure that all data gets erased and cannot be accessed by other LVs
-created later (which happen to be assigned the same physical extents).
-This is a costly operation, but may be required as a security measure
-in certain environments.
+Called "Wipe Removed Volumes" in the web UI. Zero-out data when removing LVs.
+When removing a volume, this makes sure that all data gets erased and cannot be
+accessed by other LVs created later (which happen to be assigned the same
+physical extents). This is a costly operation, but may be required as a security
+measure in certain environments.
 
 `saferemove_throughput`::
 
-- 
2.39.2

[pve-devel] applied: [PATCH v2 manager] ui: lvm: expose saferemove setting

[Thomas Lamprecht]

Am 01/02/2024 um 16:12 schrieb Fiona Ebner:
> It can be security-relevant in some environments. The LVM storage
> documentation can be reached via the "Help" button and contains a few
> more details.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> Changes in v2:
>     * Improve label text (thanks to Fabian!)
> 
>  www/manager6/storage/LVMEdit.js | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
>

applied both patches, thanks!