From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu-server 1/2] tests: improve multiarch build support
Date: Tue, 3 Feb 2026 16:09:51 +0100 [thread overview]
Message-ID: <dcccab1f-1a75-42d8-9436-e08dcca36fce@proxmox.com> (raw)
In-Reply-To: <96b3810e-bb32-4045-bbeb-f5aa4c82d3f4@proxmox.com>
Am 03.02.26 um 16:03 schrieb Dominik Csapak:
>
> alternatively, we could write out 'PVE::Tools::get_host_arch' everywhere
> without importing, then we'd only have to mock once
> (but makes the code slightly less readable)
could combine that with adding a local helper with the same name though.
While I prefer having no extra code for testing, it's not always possible
and a simple getter would be at least save to have.
next prev parent reply other threads:[~2026-02-03 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 14:16 Dominik Csapak
2026-02-03 14:16 ` [PATCH qemu-server 2/2] tests: cfg2cmd: add some architecture tests Dominik Csapak
2026-02-03 15:01 ` [PATCH qemu-server 1/2] tests: improve multiarch build support Thomas Lamprecht
2026-02-03 15:04 ` Dominik Csapak
2026-02-03 15:09 ` Thomas Lamprecht [this message]
2026-02-04 10:09 ` superseded: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcccab1f-1a75-42d8-9436-e08dcca36fce@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.