all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH cluster/guest-common/qemu-server/container/manager/docs v3 00/38] fix #7846: guest identity (uid) and cluster ID
Date: Wed, 18 Nov 2026 15:13:11 +0100	[thread overview]
Message-ID: <dc7d61dc-e263-41e2-8757-452f0a5ca55e@proxmox.com> (raw)
In-Reply-To: <5c3aa7d2-aea2-462a-80a8-bfcf95c18247@proxmox.com>

Am 18.11.26 um 14:49 schrieb Dominik Csapak:
> Read through it again (though mostly via diff from the v1)
> and it looks good to me now:
> 
> * the rationale is given
> * the flow is better visible (and with better wording)
> * remote migrate is now blocked by default on conflicting uids
> 
> the biggest issue to discuss maybe still is if we want to allow
> restore with a new uid in case the same uid exists already,
> same argument as for the remote migration:
> 
> if the same vm already exists, restoring it again can have
> bad implications like duplicate ips, etc.
> 
> but IMHO it's not a blocker, maybe even something the admin
> would want to configure globally? (datacenter.cfg?)

IMO such restores can be - while potentially not highly frequent
– part of standard procedure, like test copy, restore test or partial
recovery.

It certainly is a valid point, but as we can only do a likely
correlation that same uid == same network and thus likely bad,
one can also have the situation with a different guest uid but
same network address in both the guests. Also, I'd rather have
this improved midterm by offering to restore to a isolated or
nat'ed or so vnet, and then show a warning hint (and adapt
the defaults to make that isolated-network-env-restore) if a guest
with the uid exist.

Might come out for free for a general slightly overdue improvement
for providing some convenience foundations for easier backup
restore testing.

> one thing i noticed during testing was if i modified a guest
> to have an invalid uid, on the next config write, the
> ctime and creation-qemu vanished from the config and
> only a new rtime and uid remained.
> (though i had to manually edit the config, so not a problem IMO)

will double check, but yeah, such manual edits are a bit hard
to handle correctly; maybe we can harden some simpler/specific
cases.

> 
> there are still some nits here and there, but they are mostly
> taste questions and nothing that can't be improved further down the line
> 
> for example: when restoring a vm over another another, the failure i get is:
> 
> TASK ERROR: command 'set -o pipefail && zstd -q -d -c -- /var/lib/vz/dump/vzdump-qemu-9999-2026_11_18-14_37_58.vma.zst | vma extract -v -r /var/tmp/vzdumptmp8272.fifo - /var/tmp/vzdumptmp8272' failed: backup belongs to another guest: its uid '2xuof4nw6rnowo5mpgs2' differs from uid 'itomggi4ofm33szeb3h2' of the existing VM 102 - use 'allow-identity-mismatch' to overwrite the VM anyway
> 
> which is not very readable in the task log window  (still functional though)

true, multi-line errors would help here a lot, we support them in
rust side, need to recheck if in perl side too.

> 
> also at least a few things in the ui i'm missing:
> 
> a way to show the cluster/node id (probably in the datacenter summary)

Or cluster status view, while not coming from corosync or so
directly at least naming wise it fits. I'll see if one seems clearly
better (summary one is probably easier), else keep that out for now.

> using the uid (maybe rtime) as variables in the templating for the notes

good idea.

> Tested it on a test cluster with some backup/restore cycles,
> adopting of uid, manually editing configs, etc.
> 
> Since nothing of these blocks this series from my POV, consider it:
> 
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>

big thanks!





  reply	other threads:[~2026-11-18 14:13 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  4:37 [PATCH cluster/guest-common/qemu-server/container/manager/docs v3 00/38] fix #7846: guest identity (uid) and cluster ID Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 01/38] pmxcfs: reject changes to the cluster ID file from user space Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 02/38] pmxcfs: generate a cluster ID on standalone nodes Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 03/38] pmxcfs: dfsm: add a callback that runs once all members are in sync Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 04/38] pmxcfs: quorum: pass the corosync membership to an optional listener Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 05/38] pmxcfs: confdb: call an optional listener when the nodes get published Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 06/38] pmxcfs: dcdb: generate the cluster ID once the cluster is in sync Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 07/38] cluster: add helper to read the cluster ID Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 08/38] pmxcfs: allow removing the cluster ID file in forced local mode Thomas Lamprecht
2026-11-18  4:37 ` [PATCH guest-common v3 09/38] guest identity: add helpers for the guest uid and registration time Thomas Lamprecht
2026-11-18  4:37 ` [PATCH guest-common v3 10/38] abstract config: assign a guest identity and keep it on config writes Thomas Lamprecht
2026-11-18  4:37 ` [PATCH guest-common v3 11/38] abstract config: let the VMID reservation return the previous state Thomas Lamprecht
2026-11-18  4:37 ` [PATCH guest-common v3 12/38] guest identity: allow taking over a uid that is unused in the cluster Thomas Lamprecht
2026-11-18  4:37 ` [PATCH guest-common v3 13/38] migrate: add shared helpers for the identity command of the migration tunnel Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 14/38] api: restore: release the VMID if a restore to an unused VMID fails Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 15/38] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 16/38] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 17/38] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 18/38] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 19/38] api: status: return the guest uid Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 20/38] tests: remote migration: check a failed command and an early tunnel end Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 21/38] config: add read-only meta property with the creation time Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 22/38] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 23/38] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 24/38] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 25/38] restore: refuse overwriting a container with another guest's backup Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 26/38] test: remote migration: check the cleanup of the target after failures Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 27/38] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 28/38] api: status: return the guest uid Thomas Lamprecht
2026-11-18  4:37 ` [PATCH manager v3 29/38] api: cluster resources: add guest uid and registration time Thomas Lamprecht
2026-11-18  4:37 ` [PATCH manager v3 30/38] api: cluster status: add cluster ID Thomas Lamprecht
2026-11-18  4:37 ` [PATCH manager v3 31/38] ui: restore: allow overwriting a guest with a backup of another guest Thomas Lamprecht
2026-11-18  4:37 ` [PATCH manager v3 32/38] ui: migrate: refuse target nodes that would drop the guest identity Thomas Lamprecht
2026-11-18  4:37 ` [PATCH manager v3 33/38] ui: guest summary: show " Thomas Lamprecht
2026-11-18  4:37 ` [PATCH manager v3 34/38] api: bulk migrate: refuse targets that would drop " Thomas Lamprecht
2026-11-18  4:37 ` [PATCH docs v3 35/38] vzdump: describe the guest identity of VMs and containers Thomas Lamprecht
2026-11-18  4:37 ` [PATCH docs v3 36/38] pvecm: document the cluster ID and how to get a new one Thomas Lamprecht
2026-11-18  4:37 ` [PATCH docs v3 37/38] qm: configuration: describe the read-only meta property Thomas Lamprecht
2026-11-18  4:37 ` [PATCH docs v3 38/38] pct: " Thomas Lamprecht
2026-11-18 13:49 ` [PATCH cluster/guest-common/qemu-server/container/manager/docs v3 00/38] fix #7846: guest identity (uid) and cluster ID Dominik Csapak
2026-11-18 14:13   ` Thomas Lamprecht [this message]
2026-11-19 10:38 ` superseded: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc7d61dc-e263-41e2-8757-452f0a5ca55e@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal