all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH manager v3 33/38] ui: guest summary: show the guest identity
Date: Wed, 18 Nov 2026 05:37:45 +0100	[thread overview]
Message-ID: <20261118043817.1659212-34-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20261118043817.1659212-1-t.lamprecht@proxmox.com>

The 'meta' property of a guest now holds its identity, a unique ID that
restores and migrations from other clusters keep where possible, and
the time the guest was registered in this cluster, next to the creation
time and, for VMs, the QEMU version the VM was created with. The web UI
showed none of it, so comparing a guest with what a backup or monitoring
tool reports for it required reading the config or the API.

Show the unique ID as a quiet row in the status panel of the guest
summary, also for templates, as it is the value such tools report. A
button next to it opens a window with all these values and, for users
with Sys.Audit on '/', the cluster ID. Both IDs are in read-only text
fields, so they can be selected and copied.

The row uses the uid that the guest status already returns, so the
summary makes no extra periodic request, and the window loads the guest
config and the cluster status once when opened. A failure to load the
cluster status only leaves out the cluster ID. Guests without a uid,
for example on nodes that do not handle the identity yet, get no row.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---

no changes since v1

 www/manager6/Makefile                    |   1 +
 www/manager6/panel/GuestIdentity.js      | 142 +++++++++++++++++++++++
 www/manager6/panel/GuestStatusView.js    |   3 +
 www/manager6/panel/TemplateStatusView.js |   3 +
 4 files changed, 149 insertions(+)
 create mode 100644 www/manager6/panel/GuestIdentity.js

diff --git a/www/manager6/Makefile b/www/manager6/Makefile
index e8e2bd0b..24ad74cb 100644
--- a/www/manager6/Makefile
+++ b/www/manager6/Makefile
@@ -113,6 +113,7 @@ JSSRC= 							\
 	panel/IPView.js					\
 	panel/RunningChart.js				\
 	panel/StatusPanel.js				\
+	panel/GuestIdentity.js				\
 	panel/GuestStatusView.js			\
 	panel/GuestSummary.js				\
 	panel/TemplateStatusView.js			\
diff --git a/www/manager6/panel/GuestIdentity.js b/www/manager6/panel/GuestIdentity.js
new file mode 100644
index 00000000..d67ec7d4
--- /dev/null
+++ b/www/manager6/panel/GuestIdentity.js
@@ -0,0 +1,142 @@
+Ext.define('PVE.window.GuestIdentity', {
+    extend: 'Ext.window.Window',
+    alias: 'widget.pveGuestIdentityWindow',
+
+    title: gettext('Guest Identity'),
+    width: 450,
+    modal: true,
+    resizable: false,
+    bodyPadding: 10,
+
+    layout: 'anchor',
+    defaults: {
+        anchor: '100%',
+        labelWidth: 130,
+    },
+
+    // the parsed 'meta' property of the guest config
+    meta: {},
+    clusterId: undefined,
+
+    initComponent: function () {
+        let me = this;
+
+        let meta = me.meta;
+        let renderTime = (seconds) =>
+            Ext.isNumeric(seconds) ? PVE.Utils.render_timestamp_human_readable(seconds) : '';
+
+        let fields = [
+            {
+                xtype: 'textfield',
+                itemId: 'uid',
+                fieldLabel: gettext('Unique ID'),
+                value: meta.uid,
+                editable: false,
+            },
+            {
+                xtype: 'displayfield',
+                itemId: 'rtime',
+                fieldLabel: gettext('Registered'),
+                value: renderTime(meta.rtime / 1000),
+            },
+            {
+                xtype: 'textfield',
+                itemId: 'cluster-id',
+                fieldLabel: gettext('Cluster ID'),
+                value: me.clusterId,
+                editable: false,
+            },
+            {
+                xtype: 'displayfield',
+                itemId: 'ctime',
+                fieldLabel: gettext('Created'),
+                value: renderTime(meta.ctime),
+            },
+            {
+                xtype: 'displayfield',
+                itemId: 'creation-qemu',
+                fieldLabel: gettext('Created with QEMU'),
+                value: meta['creation-qemu'],
+            },
+        ];
+        me.items = fields.filter((field) => (field.value ?? '') !== '');
+
+        me.callParent();
+    },
+});
+
+Ext.define('PVE.panel.GuestIdentityInfo', {
+    extend: 'Ext.container.Container',
+    alias: 'widget.pveGuestIdentityInfo',
+
+    hidden: true,
+    layout: {
+        type: 'hbox',
+        align: 'middle',
+    },
+
+    items: [
+        {
+            xtype: 'pmxInfoWidget',
+            flex: 1,
+            iconCls: 'fa fa-id-card-o fa-fw',
+            title: gettext('Unique ID'),
+            printBar: false,
+            textField: 'uid',
+            // the status view only updates info widgets, so this one shows or hides the whole row
+            renderer: function (uid) {
+                this.up('pveGuestIdentityInfo').setHidden(!uid);
+                return Ext.htmlEncode(uid);
+            },
+        },
+        {
+            xtype: 'button',
+            iconCls: 'fa fa-info-circle',
+            tooltip: gettext('Details'),
+            ariaLabel: gettext('Details'),
+            ui: 'default-toolbar',
+            margin: '0 0 0 5',
+            handler: function () {
+                this.up('pveGuestIdentityInfo').showDetails();
+            },
+        },
+    ],
+
+    showDetails: async function () {
+        let me = this;
+
+        let view = me.up('pmxStatusView');
+        let { node, vmid, type } = view.pveSelNode.data;
+        let caps = Ext.state.Manager.get('GuiCap');
+
+        let [config, status] = await Promise.allSettled([
+            // not the pending values: an unfinished restore queues the uid of its backup there
+            Proxmox.Async.api2({
+                url: `/nodes/${node}/${type}/${vmid}/config`,
+                params: { current: 1 },
+                method: 'GET',
+                waitMsgTarget: view,
+            }),
+            // the cluster ID is optional, so a missing privilege or a failure only omits it
+            caps.dc['Sys.Audit']
+                ? Proxmox.Async.api2({ url: '/cluster/status', method: 'GET', waitMsgTarget: view })
+                : undefined,
+        ]);
+
+        if (config.status === 'rejected') {
+            Ext.Msg.alert(gettext('Error'), config.reason.htmlStatus);
+            return;
+        }
+
+        let meta = PVE.Parser.parsePropertyString(config.value.result.data.meta) ?? {};
+        // a standalone node reports the ID on its node entry, a cluster only on the cluster entry
+        let statusEntries = status.value?.result?.data ?? [];
+        let clusterId = statusEntries.find((entry) => entry['cluster-id'])?.['cluster-id'];
+
+        Ext.create('PVE.window.GuestIdentity', {
+            autoShow: true,
+            meta,
+            clusterId,
+        });
+    },
+});
diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js
index 315d3420..00851b07 100644
--- a/www/manager6/panel/GuestStatusView.js
+++ b/www/manager6/panel/GuestStatusView.js
@@ -92,6 +92,9 @@ Ext.define('PVE.panel.GuestStatusView', {
                 hidden: '{isQemu}',
             },
         },
+        {
+            xtype: 'pveGuestIdentityInfo',
+        },
         {
             xtype: 'box',
             height: 10,
diff --git a/www/manager6/panel/TemplateStatusView.js b/www/manager6/panel/TemplateStatusView.js
index 8742cfc2..26732386 100644
--- a/www/manager6/panel/TemplateStatusView.js
+++ b/www/manager6/panel/TemplateStatusView.js
@@ -30,6 +30,9 @@ Ext.define('PVE.panel.TemplateStatusView', {
             iconCls: 'fa fa-fw fa-building',
             title: gettext('Node'),
         },
+        {
+            xtype: 'pveGuestIdentityInfo',
+        },
         {
             xtype: 'box',
             height: 20,
-- 
2.47.3





  parent reply	other threads:[~2026-11-18  4:42 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  4:37 [PATCH cluster/guest-common/qemu-server/container/manager/docs v3 00/38] fix #7846: guest identity (uid) and cluster ID Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 01/38] pmxcfs: reject changes to the cluster ID file from user space Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 02/38] pmxcfs: generate a cluster ID on standalone nodes Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 03/38] pmxcfs: dfsm: add a callback that runs once all members are in sync Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 04/38] pmxcfs: quorum: pass the corosync membership to an optional listener Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 05/38] pmxcfs: confdb: call an optional listener when the nodes get published Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 06/38] pmxcfs: dcdb: generate the cluster ID once the cluster is in sync Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 07/38] cluster: add helper to read the cluster ID Thomas Lamprecht
2026-11-18  4:37 ` [PATCH cluster v3 08/38] pmxcfs: allow removing the cluster ID file in forced local mode Thomas Lamprecht
2026-11-18  4:37 ` [PATCH guest-common v3 09/38] guest identity: add helpers for the guest uid and registration time Thomas Lamprecht
2026-11-18  4:37 ` [PATCH guest-common v3 10/38] abstract config: assign a guest identity and keep it on config writes Thomas Lamprecht
2026-11-18  4:37 ` [PATCH guest-common v3 11/38] abstract config: let the VMID reservation return the previous state Thomas Lamprecht
2026-11-18  4:37 ` [PATCH guest-common v3 12/38] guest identity: allow taking over a uid that is unused in the cluster Thomas Lamprecht
2026-11-18  4:37 ` [PATCH guest-common v3 13/38] migrate: add shared helpers for the identity command of the migration tunnel Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 14/38] api: restore: release the VMID if a restore to an unused VMID fails Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 15/38] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 16/38] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 17/38] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 18/38] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 19/38] api: status: return the guest uid Thomas Lamprecht
2026-11-18  4:37 ` [PATCH qemu-server v3 20/38] tests: remote migration: check a failed command and an early tunnel end Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 21/38] config: add read-only meta property with the creation time Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 22/38] fix #7846: config: add a guest identity to the 'meta' property Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 23/38] api: migrate, clone: refuse targets that would drop the guest identity Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 24/38] restore: take over the guest uid from the backup where possible Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 25/38] restore: refuse overwriting a container with another guest's backup Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 26/38] test: remote migration: check the cleanup of the target after failures Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 27/38] api: remote migration: take over the guest uid from the source Thomas Lamprecht
2026-11-18  4:37 ` [PATCH container v3 28/38] api: status: return the guest uid Thomas Lamprecht
2026-11-18  4:37 ` [PATCH manager v3 29/38] api: cluster resources: add guest uid and registration time Thomas Lamprecht
2026-11-18  4:37 ` [PATCH manager v3 30/38] api: cluster status: add cluster ID Thomas Lamprecht
2026-11-18  4:37 ` [PATCH manager v3 31/38] ui: restore: allow overwriting a guest with a backup of another guest Thomas Lamprecht
2026-11-18  4:37 ` [PATCH manager v3 32/38] ui: migrate: refuse target nodes that would drop the guest identity Thomas Lamprecht
2026-11-18  4:37 ` Thomas Lamprecht [this message]
2026-11-18  4:37 ` [PATCH manager v3 34/38] api: bulk migrate: refuse targets " Thomas Lamprecht
2026-11-18  4:37 ` [PATCH docs v3 35/38] vzdump: describe the guest identity of VMs and containers Thomas Lamprecht
2026-11-18  4:37 ` [PATCH docs v3 36/38] pvecm: document the cluster ID and how to get a new one Thomas Lamprecht
2026-11-18  4:37 ` [PATCH docs v3 37/38] qm: configuration: describe the read-only meta property Thomas Lamprecht
2026-11-18  4:37 ` [PATCH docs v3 38/38] pct: " Thomas Lamprecht
2026-11-18 13:49 ` [PATCH cluster/guest-common/qemu-server/container/manager/docs v3 00/38] fix #7846: guest identity (uid) and cluster ID Dominik Csapak
2026-11-18 14:13   ` Thomas Lamprecht
2026-11-19 10:38 ` superseded: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261118043817.1659212-34-t.lamprecht@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal