From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Michael Köppl" <m.koeppl@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v3 1/1] close #3181: ui: display guest name in confirm dialogs
Date: Mon, 7 Apr 2025 14:16:38 +0200 [thread overview]
Message-ID: <dc49c134-6e1f-4214-95f1-f50696618f34@proxmox.com> (raw)
In-Reply-To: <20250407083806.63773-3-m.koeppl@proxmox.com>
Am 07.04.25 um 10:38 schrieb Michael Köppl:
> The confirmation dialogs of the following actions are affected by this
> change:
> * Remove
> * Clone
> * Migrate
> * Snapshot
> * Snapshot restore
> * Backup VM/CT from config view
> * Restore VM/CT from config view
>
> A combination of VM/CT id and name is added to each confirmation dialog.
> The order of id and name depends on the sort field selected in the tree
> settings. If "Name" is selected, the confirmation dialogs will show "VM
> name (VMID)". In any other case, "VMID (VM name)" will be used.
>
> The VM/CT name is considered optional in all handled cases. If it is
> undefined, only the VMID will be displayed in the dialog window. No
> exceptions are thrown in case of an undefined guest name because it
> only extends the information displayed to the user and is not essential
> for performing any of the actions above.
>
> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
> ---
> www/manager6/Utils.js | 13 ++++++++++++-
> www/manager6/grid/BackupView.js | 4 ++++
> www/manager6/lxc/CmdMenu.js | 9 ++++++++-
> www/manager6/lxc/Config.js | 15 +++++++++++++--
> www/manager6/qemu/CmdMenu.js | 9 ++++++++-
> www/manager6/qemu/Config.js | 15 +++++++++++++--
> www/manager6/tree/SnapshotTree.js | 12 ++++++++++--
> www/manager6/window/Backup.js | 6 +++---
> www/manager6/window/Clone.js | 7 +++++--
> www/manager6/window/Migrate.js | 10 ++++++++--
> www/manager6/window/Restore.js | 3 ++-
> www/manager6/window/Snapshot.js | 7 ++++++-
> 12 files changed, 92 insertions(+), 18 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-04-07 12:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 8:38 [pve-devel] [PATCH manager/widget-toolkit v3 0/2] " Michael Köppl
2025-04-07 8:38 ` [pve-devel] [PATCH widget-toolkit v3 1/1] close #3181: ui: add formatted guest identifier to safe destroy dialog window Michael Köppl
2025-04-07 12:05 ` [pve-devel] applied: " Thomas Lamprecht
2025-04-07 8:38 ` [pve-devel] [PATCH manager v3 1/1] close #3181: ui: display guest name in confirm dialogs Michael Köppl
2025-04-07 12:16 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc49c134-6e1f-4214-95f1-f50696618f34@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal