From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu 1/2] update submodule and patches to QEMU 10.2.1
Date: Tue, 17 Mar 2026 17:58:55 +0100 [thread overview]
Message-ID: <dc3493fe-35e1-423f-b2f9-1594e15e785c@proxmox.com> (raw)
In-Reply-To: <20260312114417.82984-2-f.ebner@proxmox.com>
Am 12.03.26 um 13:13 schrieb Fiona Ebner:
> @@ -715,7 +715,12 @@ index 0000000000..56e0fa6c69
> +
> + migration_incoming_state_destroy();
> + if (ret < 0) {
> -+ error_setg_errno(errp, -ret, "Error while loading VM state");
> ++ if (local_err) {
> ++ error_setg_errno(errp, -ret, "Error while loading VM state - %s",
> ++ error_get_pretty(local_err));
Would we need to free the local_err here? But in any case a tiny nit
and not really relevant in terms of leaking memory due to being in
a rather unlikely error branch.
> ++ } else {
> ++ error_setg_errno(errp, -ret, "Error while loading VM state");
> ++ }
> + goto the_end;
> + }
> +
next prev parent reply other threads:[~2026-03-17 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 11:44 [PATCH-SERIES qemu 0/2] " Fiona Ebner
2026-03-12 11:44 ` [PATCH qemu 1/2] update submodule and patches to " Fiona Ebner
2026-03-17 16:58 ` Thomas Lamprecht [this message]
2026-03-12 11:44 ` [PATCH qemu 2/2] stable fixes for " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc3493fe-35e1-423f-b2f9-1594e15e785c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.