all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>,
	Stefan Sterz <s.sterz@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] tape: fix anchoring of datastore map regex
Date: Wed, 29 Mar 2023 14:07:53 +0200	[thread overview]
Message-ID: <dbf56c2e-921c-a8b7-cfcb-ab0d589de307@proxmox.com> (raw)
In-Reply-To: <7a52e4c5-c8ca-e9e9-8a62-3aaa5a1d38f0@proxmox.com>

Am 29/03/2023 um 13:54 schrieb Dominik Csapak:
>> small question: should the `(:?` be a non-capturing group (`(?:`) here
>> instead? or am i missing something? afaict this would allow colons at
>> the beginning of the source datastore, creating a similar problem as was
>> fixed here, i'd assume.

good catch!

> yep, you're right, should be '(?:' instead
> 
> 
> at least 2 other regex also have this wrong:
> 
> ----
> pub BLOCKDEVICE_NAME_REGEX = r"^(:?(:?h|s|x?v)d[a-z]+)|(:?nvme\d+n\d+)$";
> ----
> 
> and
> 
> ----
> pub TAPE_RESTORE_SNAPSHOT_REGEX = concat!(r"^", PROXMOX_SAFE_ID_REGEX_STR!(), r"
> ----
> 
> will send a patch...

please also ensure that the capture.group access ID is still right then,
if used


      reply	other threads:[~2023-03-29 12:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29 10:06 Dominik Csapak
2023-03-29 10:08 ` Thomas Lamprecht
2023-03-29 11:50 ` Stefan Sterz
2023-03-29 11:54   ` Dominik Csapak
2023-03-29 12:07     ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbf56c2e-921c-a8b7-cfcb-ab0d589de307@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal