From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu] fix #2874: SATA: avoid unsolicited write to sector 0 during reset
Date: Tue, 26 Sep 2023 11:33:55 +0200 [thread overview]
Message-ID: <dbc025a4-670e-4eca-8629-2f7677530c26@proxmox.com> (raw)
In-Reply-To: <20230824135111.621128-1-f.ebner@proxmox.com>
Am 24/08/2023 um 15:51 schrieb Fiona Ebner:
> If there is a pending DMA operation during ide_bus_reset(), the fact
> that the IDEstate is already reset before the operation is canceled
> can be problematic. In particular, ide_dma_cb() might be called and
> then use the reset IDEstate which contains the signature after the
> reset. When used to construct the IO operation this leads to
> ide_get_sector() returning 0 and nsector being 1. This is particularly
> bad, because a write command will thus destroy the first sector which
> often contains a partition table or similar.
>
> Upstream discussion:
> https://lists.nongnu.org/archive/html/qemu-devel/2023-08/msg04239.html
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> ...cel-async-DMA-operation-before-reset.patch | 100 ++++++++++++++++++
> debian/patches/series | 1 +
> 2 files changed, 101 insertions(+)
> create mode 100644 debian/patches/extra/0012-hw-ide-reset-cancel-async-DMA-operation-before-reset.patch
>
>
applied, thanks!
prev parent reply other threads:[~2023-09-26 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 13:51 [pve-devel] " Fiona Ebner
2023-09-25 9:16 ` Fiona Ebner
2023-09-26 9:33 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbc025a4-670e-4eca-8629-2f7677530c26@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.