all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] tape: lto: increase default timeout to 10 minutes
Date: Tue, 3 Aug 2021 09:19:37 +0200	[thread overview]
Message-ID: <db820f54-385b-8e7b-6cce-a636cf06d5eb@proxmox.com> (raw)
In-Reply-To: <20210803062833.329477-1-d.csapak@proxmox.com>

applied

On 8/3/21 8:28 AM, Dominik Csapak wrote:
> it seems that for some actions or in some circumstances, two minutes is
> simply too short and the command aborts. Increase the default timeout to
> 10 minutes.
>
> While it should give most commands enough time to finish, in case of a real
> failure the procedure now takes up to 5 times longer, but IMHO thats an
> OK tradeoff.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>   src/tape/drive/lto/sg_tape.rs | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/tape/drive/lto/sg_tape.rs b/src/tape/drive/lto/sg_tape.rs
> index 4508f6f3..893ece5d 100644
> --- a/src/tape/drive/lto/sg_tape.rs
> +++ b/src/tape/drive/lto/sg_tape.rs
> @@ -130,7 +130,7 @@ pub struct SgTape {
>   
>   impl SgTape {
>   
> -    const SCSI_TAPE_DEFAULT_TIMEOUT: usize = 60*2; // 2 minutes
> +    const SCSI_TAPE_DEFAULT_TIMEOUT: usize = 60*10; // 10 minutes
>   
>       /// Create a new instance
>       ///




      reply	other threads:[~2021-08-03  7:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  6:28 [pbs-devel] " Dominik Csapak
2021-08-03  7:19 ` Dietmar Maurer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db820f54-385b-8e7b-6cce-a636cf06d5eb@proxmox.com \
    --to=dietmar@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal