From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Max Carrara <m.carrara@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH proxmox v2 02/12] notify: add api for webhook targets
Date: Mon, 22 Jul 2024 09:32:06 +0200 [thread overview]
Message-ID: <db4508c7-85c4-4128-92ac-b139c78e7fc8@proxmox.com> (raw)
In-Reply-To: <D2RXASXW8ZRH.ERGRVTAI7K5I@proxmox.com>
On 2024-07-17 17:35, Max Carrara wrote:
>> +
>> + assert_eq!(secrets[1].name, "token".to_string());
>> + assert_eq!(secrets[1].value, Some(encode("secret")));
>> + assert_eq!(secrets[0].name, "token2".to_string());
>> + assert_eq!(secrets[0].value, Some(encode("newsecret")));
>> +
>> + // Test property deletion
>> + update_endpoint(
>> + &mut config,
>> + "webhook-endpoint",
>> + Default::default(),
>> + Some(&[DeleteableWebhookProperty::Comment, DeleteableWebhookProperty::Secret]),
>
> You missed a `cargo fmt` here ;)
>
Right... Thanks! Was too used to RustRover autoformatting everything on save, which
I have not set up in my current nvim setup yet.
--
- Lukas
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
WARNING: multiple messages have this Message-ID
From: Lukas Wagner <l.wagner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Max Carrara <m.carrara@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [pve-devel] [PATCH proxmox v2 02/12] notify: add api for webhook targets
Date: Mon, 22 Jul 2024 09:32:06 +0200 [thread overview]
Message-ID: <db4508c7-85c4-4128-92ac-b139c78e7fc8@proxmox.com> (raw)
In-Reply-To: <D2RXASXW8ZRH.ERGRVTAI7K5I@proxmox.com>
On 2024-07-17 17:35, Max Carrara wrote:
>> +
>> + assert_eq!(secrets[1].name, "token".to_string());
>> + assert_eq!(secrets[1].value, Some(encode("secret")));
>> + assert_eq!(secrets[0].name, "token2".to_string());
>> + assert_eq!(secrets[0].value, Some(encode("newsecret")));
>> +
>> + // Test property deletion
>> + update_endpoint(
>> + &mut config,
>> + "webhook-endpoint",
>> + Default::default(),
>> + Some(&[DeleteableWebhookProperty::Comment, DeleteableWebhookProperty::Secret]),
>
> You missed a `cargo fmt` here ;)
>
Right... Thanks! Was too used to RustRover autoformatting everything on save, which
I have not set up in my current nvim setup yet.
--
- Lukas
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-07-22 7:32 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 11:27 [pve-devel] [RFC many v2 00/12] notifications: add support for webhook endpoints Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] " Lukas Wagner
2024-07-12 11:27 ` [pve-devel] [PATCH proxmox v2 01/12] notify: implement webhook targets Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] " Lukas Wagner
2024-07-17 15:35 ` [pve-devel] " Max Carrara
2024-07-17 15:35 ` Max Carrara
2024-07-22 7:30 ` [pve-devel] " Lukas Wagner
2024-07-22 7:30 ` [pbs-devel] [pve-devel] " Lukas Wagner
2024-07-22 9:41 ` [pve-devel] [pbs-devel] " Max Carrara
2024-07-22 9:41 ` [pbs-devel] [pve-devel] " Max Carrara
2024-07-12 11:27 ` [pve-devel] [PATCH proxmox v2 02/12] notify: add api for " Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] " Lukas Wagner
2024-07-17 15:35 ` [pve-devel] " Max Carrara
2024-07-17 15:35 ` [pbs-devel] " Max Carrara
2024-07-22 7:32 ` Lukas Wagner [this message]
2024-07-22 7:32 ` Lukas Wagner
2024-07-12 11:27 ` [pve-devel] [PATCH proxmox-perl-rs v2 03/12] common: notify: add bindings for webhook API routes Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] " Lukas Wagner
2024-07-17 15:35 ` [pve-devel] " Max Carrara
2024-07-17 15:35 ` [pbs-devel] " Max Carrara
2024-07-12 11:27 ` [pve-devel] [PATCH proxmox-perl-rs v2 04/12] common: notify: add bindings for get_targets Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] " Lukas Wagner
2024-07-17 15:36 ` [pve-devel] " Max Carrara
2024-07-17 15:36 ` Max Carrara
2024-07-12 11:27 ` [pve-devel] [PATCH widget-toolkit v2 05/12] notification: add UI for adding/updating webhook targets Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] " Lukas Wagner
2024-07-12 11:27 ` [pve-devel] [PATCH manager v2 06/12] api: notifications: use get_targets impl from proxmox-notify Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] " Lukas Wagner
2024-07-12 11:27 ` [pve-devel] [PATCH manager v2 07/12] api: add routes for webhook notification endpoints Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] " Lukas Wagner
2024-07-17 15:36 ` [pve-devel] " Max Carrara
2024-07-17 15:36 ` Max Carrara
2024-07-22 7:37 ` [pve-devel] " Lukas Wagner
2024-07-22 7:37 ` [pbs-devel] [pve-devel] " Lukas Wagner
2024-07-22 9:50 ` [pve-devel] [pbs-devel] " Max Carrara
2024-07-22 9:50 ` [pbs-devel] [pve-devel] " Max Carrara
2024-07-22 13:56 ` [pve-devel] [pbs-devel] " Thomas Lamprecht
2024-07-22 13:56 ` [pbs-devel] [pve-devel] " Thomas Lamprecht
2024-07-12 11:27 ` [pve-devel] [PATCH proxmox-backup v2 09/12] api: notification: add API routes for webhook targets Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] " Lukas Wagner
2024-07-12 11:27 ` [pve-devel] [PATCH proxmox-backup v2 10/12] ui: utils: enable webhook edit window Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] " Lukas Wagner
2024-07-12 11:27 ` [pve-devel] [PATCH proxmox-mail-forward v2 12/12] bump proxmox-notify dependency Lukas Wagner
2024-07-12 11:27 ` [pbs-devel] " Lukas Wagner
2024-07-17 15:34 ` [pve-devel] [RFC many v2 00/12] notifications: add support for webhook endpoints Max Carrara
2024-07-17 15:34 ` [pbs-devel] " Max Carrara
2024-07-22 7:50 ` Lukas Wagner
2024-07-22 7:50 ` [pbs-devel] " Lukas Wagner
2024-07-22 12:10 ` Stefan Hanreich
2024-07-22 12:10 ` [pbs-devel] " Stefan Hanreich
2024-07-22 12:29 ` Lukas Wagner
2024-07-22 12:29 ` [pbs-devel] " Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db4508c7-85c4-4128-92ac-b139c78e7fc8@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal