From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Sterz <s.sterz@proxmox.com>
Subject: Re: [pve-devel] [PATCH access-control] ldap: fix ldap distinguished names regex
Date: Sun, 28 May 2023 19:50:59 +0200 [thread overview]
Message-ID: <d92ca8e5-2488-e313-4425-aa786ebe3e60@proxmox.com> (raw)
In-Reply-To: <afc2641e-64ec-08b4-e083-9669e85d2818@proxmox.com>
Am 17/05/2023 um 15:42 schrieb Stefan Sterz:
> sorry just noticed i forgot: adding tests for this was
>
> Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
I mean, it's really great that we finally get some tests here and if only
Dominik statement made you do it, then chapeau to him! But, Suggested-by's
should be mostly for suggestion on implementation (details), as you all
definitively have a blanket statement from me, and I'd think it's safe to say
also from all other maintainers, to add tests!
I mean, great if that was all needed to solve the motivation to write tests
in developers ;-P
next prev parent reply other threads:[~2023-05-28 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 13:39 Stefan Sterz
2023-05-17 13:42 ` Stefan Sterz
2023-05-28 17:50 ` Thomas Lamprecht [this message]
2023-05-23 6:58 ` Christoph Heiss
2023-05-23 8:56 ` Stefan Sterz
2023-05-23 10:12 ` Christoph Heiss
2023-05-23 12:17 ` Stefan Sterz
2023-05-25 9:52 ` Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d92ca8e5-2488-e313-4425-aa786ebe3e60@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.