From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-yew-mobile-gui] fix submodules paths to work with git.proxmox.com
Date: Thu, 14 Aug 2025 15:20:40 +0200 [thread overview]
Message-ID: <d8d33d47-0bbc-47a4-9f1e-4ce8026d72a4@proxmox.com> (raw)
In-Reply-To: <1754907401.77n5dfayqp.astroid@yuna.none>
On 11/08/2025 12:18, Fabian Grünbichler wrote:
> On August 8, 2025 9:17 pm, Kamil Trzcinski wrote:
>> Submodules refer to private git+ssh url.
>> Use git.proxmox.com equivalents.
>> ---
>> .gitmodules | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/.gitmodules b/.gitmodules
>> index fd84194..0e2d332 100644
>> --- a/.gitmodules
>> +++ b/.gitmodules
>> @@ -1,6 +1,6 @@
>> [submodule "pwt-assets"]
>> path = pwt-assets
>> - url = gitolite3@proxdev.maurer-it.com:yew/proxmox-yew-widget-toolkit-assets
>> + url = git://git.proxmox.com/git/ui/proxmox-yew-widget-toolkit-assets.git
>
> we often use relative urls that work for both servers, but I am not sure
> whether that would work here..
>
> @Dietmar: thoughts?
It's much simpler to just use the absolute URL, that always work.
The relative path is an optimization and can still be enabled by
adapting the path manually locally, but in anyway that's less a
problem compared to not being able to clone at all without hacking
around, which is a horrible experience...
>> [submodule "proxmox-api-types"]
>> path = proxmox-api-types
>> - url = gitolite3@proxdev.maurer-it.com:/rust/proxmox-api-types
>> + url = git://git.proxmox.com/git/proxmox-api-types.git
>> --
>> 2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-14 13:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 19:17 Kamil Trzcinski
2025-08-11 10:18 ` Fabian Grünbichler
2025-08-11 10:22 ` Kamil Trzciński
2025-08-14 13:20 ` Thomas Lamprecht [this message]
2025-09-02 12:59 ` [pve-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8d33d47-0bbc-47a4-9f1e-4ce8026d72a4@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.