all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pbs-devel] applied: [PATCH backup] use BufReader/Writer for Files passed to serde_json::from_reader/writer
Date: Wed, 6 Apr 2022 16:41:02 +0200	[thread overview]
Message-ID: <d7c18a01-5603-45c1-3bbe-ffa04e4e9b62@proxmox.com> (raw)
In-Reply-To: <20220406125112.37327-1-w.bumiller@proxmox.com>

On 06.04.22 14:51, Wolfgang Bumiller wrote:
> As serde_json will otherwise read files 1 byte at a time.
> Writing is a bit better, but syntacitcal elements (quotes, braces,
> commas) still often show up as single write syscalls, so use BufWriter
> there as well.
> 
> Note that while we do store the file in the resulting objects, we do not
> need to keep the buffered read/writers as we always `seek` to the
> beginning on further file operations.
> 
> Reported-by: Mark Schouten <mark@tuxis.nl>
> Link: https://lists.proxmox.com/pipermail/pbs-devel/2022-April/004909.html
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> @Mark: Hope the Reported-by tag is fine with you.
> 
>  proxmox-file-restore/src/block_driver_qemu.rs | 8 ++++----
>  src/config/tfa.rs                             | 6 +++---
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
>

applied, thanks!




  reply	other threads:[~2022-04-06 14:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06 12:51 [pbs-devel] " Wolfgang Bumiller
2022-04-06 14:41 ` Thomas Lamprecht [this message]
2022-04-07 15:04 ` Mark Schouten

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d7c18a01-5603-45c1-3bbe-ffa04e4e9b62@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal