From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 manager 3/4] ui: BusTypeSelector: change noVirtIO to withVirtIO
Date: Thu, 10 Mar 2022 12:24:40 +0100 [thread overview]
Message-ID: <d7607ec8-97c1-aecf-492a-d38a19a8e8db@proxmox.com> (raw)
In-Reply-To: <20220307100722.257128-4-a.lauterer@proxmox.com>
Am 07.03.22 um 11:07 schrieb Aaron Lauterer:
> Double negated properties make it harder than necessary to parse
> conditions.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> www/manager6/form/BusTypeSelector.js | 4 ++--
> www/manager6/form/ControllerSelector.js | 4 ++--
> www/manager6/qemu/CDEdit.js | 2 +-
> www/manager6/qemu/CIDriveEdit.js | 2 +-
> 4 files changed, 6 insertions(+), 6 deletions(-)
>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
next prev parent reply other threads:[~2022-03-10 11:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 10:07 [pve-devel] [PATCH v3 manager 0/4] ui: lxc/qemu: add reassign for disks and volumes Aaron Lauterer
2022-03-07 10:07 ` [pve-devel] [PATCH v3 manager 1/4] ui: lxc/qemu: add disk reassign and action submenu Aaron Lauterer
2022-03-10 10:49 ` Fabian Ebner
2022-03-11 14:38 ` Aaron Lauterer
2022-03-14 8:18 ` Fabian Ebner
2022-03-14 8:19 ` Aaron Lauterer
2022-03-07 10:07 ` [pve-devel] [PATCH v3 manager 2/4] ui: lxc/qemu: disk/volume action simplify menu items Aaron Lauterer
2022-03-07 10:07 ` [pve-devel] [PATCH v3 manager 3/4] ui: BusTypeSelector: change noVirtIO to withVirtIO Aaron Lauterer
2022-03-10 11:24 ` Fabian Ebner [this message]
2022-03-07 10:07 ` [pve-devel] [PATCH v3 manager 4/4] ui: hdmove: modernize/refactor Aaron Lauterer
2022-03-10 11:19 ` Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7607ec8-97c1-aecf-492a-d38a19a8e8db@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal