all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pbs-devel] [PATCH proxmox-backup] server: push: fix supported api version check
@ 2024-11-28 11:56 Christian Ebner
  2024-11-28 11:59 ` [pbs-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Ebner @ 2024-11-28 11:56 UTC (permalink / raw)
  To: pbs-devel

The current version check does not cover cases where the minor
version is 3, but the release version is below 11. Fix this by
extending the check accordingly.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/server/push.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/server/push.rs b/src/server/push.rs
index 53098d43b..afc4ec815 100644
--- a/src/server/push.rs
+++ b/src/server/push.rs
@@ -134,7 +134,8 @@ impl PushParameters {
         }
 
         let supports_prune_delete_stats = api_version.major > 3
-            || (api_version.major == 3 && api_version.minor >= 2 && api_version.release >= 11);
+            || (api_version.major == 3 && api_version.minor == 2 && api_version.release >= 11)
+            || (api_version.major == 3 && api_version.minor >= 3);
 
         let target = PushTarget {
             remote,
-- 
2.39.5



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pbs-devel] applied: [PATCH proxmox-backup] server: push: fix supported api version check
  2024-11-28 11:56 [pbs-devel] [PATCH proxmox-backup] server: push: fix supported api version check Christian Ebner
@ 2024-11-28 11:59 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-11-28 11:59 UTC (permalink / raw)
  To: Proxmox Backup Server development discussion, Christian Ebner

Am 28.11.24 um 12:56 schrieb Christian Ebner:
> The current version check does not cover cases where the minor
> version is 3, but the release version is below 11. Fix this by
> extending the check accordingly.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  src/server/push.rs | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied, but re-ordered the lines to go from bigger to smaller, thanks!


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-28 11:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-28 11:56 [pbs-devel] [PATCH proxmox-backup] server: push: fix supported api version check Christian Ebner
2024-11-28 11:59 ` [pbs-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal