all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: [pdm-devel] applied: [PATCH proxmox] sys: fs: derive `Copy` for CreateOptions
Date: Wed, 29 Jan 2025 18:10:28 +0100	[thread overview]
Message-ID: <d6bfbd46-df87-40f6-8d70-dd72a2ddfd26@proxmox.com> (raw)
In-Reply-To: <20250129091739.90323-1-l.wagner@proxmox.com>

Am 29.01.25 um 10:17 schrieb Lukas Wagner:
> Pretty much all functions accepting `CreateOptions` take a value and not
> a reference, so I've found myself using `.clone()` quite often in code
> I've written recently.
> The struct is only 24 bytes large (verified by a
> `std::mem::size_of::<CreateOptions>()`), so it should be absolutely fine
> to just derive Copy for it.
> 
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  proxmox-sys/src/fs/mod.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


      reply	other threads:[~2025-01-29 17:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29  9:17 [pdm-devel] " Lukas Wagner
2025-01-29 17:10 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6bfbd46-df87-40f6-8d70-dd72a2ddfd26@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal