Re: [pbs-devel] [PATCH proxmox-backup 1/6] backup: hierarchy: add new can_access_any_namespace_in_range helper

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
	Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/6] backup: hierarchy: add new can_access_any_namespace_in_range helper
Date: Fri, 3 Oct 2025 12:21:42 +0200	[thread overview]
Message-ID: <d65cc6cd-1a4b-4ced-998c-ae7f5db2d355@proxmox.com> (raw)
In-Reply-To: <b6f344d1-660d-4603-bae5-dac5a580f2e0@proxmox.com>

Am 03.10.25 um 12:10 schrieb Dominik Csapak:
>>> +    let mut iter = if let Ok(iter) = store.recursive_iter_backup_ns_ok(ns, max_depth) {
>>> +        iter
>>> +    } else {
>>> +        return false;
>>> +    };
>>
>> This could use let-else, e.g. something like (untested):
>>
>> let Ok(mut iter) = store.recursive_iter_backup_ns_ok(ns, max_depth) else {
>>      return false;
>> };
>>
> 
> can do, i wanted to stay as close as the original code as possible so
> it's easier to see that the code only moved
> 
> should i do that cleanup as an extra commit or should i include it in this one?

Both are fine, personally I think it would be OK to change in one go as it's
not a complex tranformation and `git show --color-words=.` (or any advanced
pager) will show that the expression returning the iter stayed the same.

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel