From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2] fix #5106: ui: ceph status: make column wrap the summary text on expand
Date: Mon, 19 Feb 2024 14:28:19 +0100 [thread overview]
Message-ID: <d62bfcc6-b270-4f79-b91f-32971c082e57@proxmox.com> (raw)
In-Reply-To: <20231207133558.566788-1-d.csapak@proxmox.com>
Am 07.12.23 um 14:35 schrieb Dominik Csapak:
> with this the title is now completely visible when the column is
> expanded, even if it's originally too narrow.
>
> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
> @@ -139,6 +149,12 @@ Ext.define('PVE.node.CephStatus', {
> {
> dataIndex: 'summary',
> header: gettext('Summary'),
> + renderer: function(value, metaData,record, rI, cI, store, view) {
eslint complains about missing space after ',' here
> + if (record.get('expanded')) {
> + metaData.tdCls = 'pmx-column-wrapped';
> + }
> + return value;
> + },
> flex: 1,
> },
> {
next prev parent reply other threads:[~2024-02-19 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 13:35 Dominik Csapak
2024-02-19 13:28 ` Fiona Ebner [this message]
2024-02-19 13:57 ` [pve-devel] applied: " Thomas Lamprecht
2024-02-19 13:59 ` Dominik Csapak
2024-02-19 14:07 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d62bfcc6-b270-4f79-b91f-32971c082e57@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.