From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Nicholas Sherlock <nick@nicksherlock.com>
Subject: Re: [pve-devel] [PATCH v2 qemu-server 0/1] pci: allow override of PCI vendor/device ids
Date: Thu, 20 Jan 2022 16:48:33 +0100 [thread overview]
Message-ID: <d615a37b-5398-fc89-4b9e-3400ab6b5836@proxmox.com> (raw)
In-Reply-To: <0100017e6f20a655-ab37d914-86d7-4a80-a82e-1293bef516b0-000000@email.amazonses.com>
On 1/18/22 22:38, Nicholas Sherlock wrote:
> In this version, changed proposed x-pci-device-id names to remove x-pci- prefix to shorten configs, and improved Perl code style, thanks to Dominik Csapak
>
> [PATCH v2 qemu-server] pci: allow override of PCI vendor/device ids
> [PATCH v2 pve-manager] ui: pci passthrough: editor for pci-id
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
Thanks,
2 nits left (you could send a v3, or we can fix it up, please
write what you prefer)
* the commit message should not have lines longer than 70 characters[0]
* and the gettext is not optimal, i'd omit the 'Set ' prefix (sorry i did not
catch it the first time), so 'Vendor ID' instead of 'Set vendor ID'
otherwise:
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
0: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages
next prev parent reply other threads:[~2022-01-20 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <pci-id-override2@nicksherlock.com>
2022-01-18 21:38 ` Nicholas Sherlock
2022-01-20 15:48 ` Dominik Csapak [this message]
2022-01-20 21:21 ` Nicholas Sherlock
2022-01-18 21:38 ` [pve-devel] [PATCH v2 qemu-server] " Nicholas Sherlock
2022-01-25 10:02 ` [pve-devel] applied: " Thomas Lamprecht
2022-01-18 21:38 ` [pve-devel] [PATCH v2 pve-manager] ui: pci passthrough: editor for pci-id overrides Nicholas Sherlock
2022-01-27 14:21 ` [pve-devel] applied: " Thomas Lamprecht
[not found] ` <0100017e9be9fa51-bfe8d998-0793-4d1a-8403-26d7b78478ac-000000@email.amazonses.com>
2022-01-28 9:38 ` Nicholas Sherlock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d615a37b-5398-fc89-4b9e-3400ab6b5836@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=nick@nicksherlock.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.