From: Mira Limbeck <m.limbeck@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH access-control] fix #4074: increase API OpenID code size limit to 2048
Date: Mon, 20 Jun 2022 11:11:15 +0200 [thread overview]
Message-ID: <d60e8e92-3349-80fd-f265-0fbbac5cebe7@proxmox.com> (raw)
In-Reply-To: <20220617084236.aoss7otwx3ee6on7@wobu-vie.proxmox.com>
On 6/17/22 10:42, Wolfgang Bumiller wrote:
> On Wed, Jun 15, 2022 at 04:09:50PM +0200, Mira Limbeck wrote:
>> Azure AD seems to have a variable authorization code size, depending on
>> the browser state according to one report in bug #4074 [0].
>>
>> Sometimes the size is greater than our current limit of 1024, so
>> increase it to 2048.
> Would there be any downside to just going straight to 4 or 8K here?
>
I don't think so. I just went with the usual `increase it to handle the
current requirements` approach here.
If you prefer a higher limit then sure, I'll send a v2 with 4k or 8k.
The mentions in the bug tracker/forum post were of code sizes about
1100-1300 in length.
next prev parent reply other threads:[~2022-06-20 9:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 14:09 Mira Limbeck
2022-06-17 8:42 ` Wolfgang Bumiller
2022-06-20 9:11 ` Mira Limbeck [this message]
2022-06-23 9:46 ` [pve-devel] applied: " Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d60e8e92-3349-80fd-f265-0fbbac5cebe7@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.