From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Yew framework devel list at Proxmox <yew-devel@lists.proxmox.com>
Subject: Re: [yew-devel] [PATCH proxmox-yew-widget-toolkit 1/1] space: fix space calculation for pwt units
Date: Fri, 31 Jan 2025 10:33:31 +0100 [thread overview]
Message-ID: <d57a891d-a140-4175-993f-aeed4a94b676@proxmox.com> (raw)
In-Reply-To: <bf35d659-6aaf-473f-b3e8-90ac621bf696@proxmox.com>
On 1/31/25 10:31, Thomas Lamprecht wrote:
> Am 30.01.25 um 19:29 schrieb Stefan Hanreich:
>> The px here is unnecessary and causes the calc expression to be
>> invalid. Since pwt-spacer-base-width is already defined in px we can
>> simply remove it.
>
> Was anything actually broken, or how did you notice this?
noticed it with a DataTable and trees, where levels > 2 would have no
indentation (should've included it in the commit msg, sorry)
_______________________________________________
yew-devel mailing list
yew-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/yew-devel
prev parent reply other threads:[~2025-01-31 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 18:29 Stefan Hanreich
2025-01-31 8:10 ` [yew-devel] applied: " Dietmar Maurer
2025-01-31 9:31 ` [yew-devel] " Thomas Lamprecht
2025-01-31 9:33 ` Stefan Hanreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d57a891d-a140-4175-993f-aeed4a94b676@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=yew-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal