Re: [pve-devel] [PATCH widget-toolkit] fix #5836: ui: translate systemd states in ServiceView

[Lukas Wagner <l.wagner@proxmox.com>]

Thanks for giving this a shot!

One comment inline

On  2024-11-08 13:52, Timothy Nicholson wrote:
> With this patch, all systemd states and unit states in the service
> view use gettext to be translated.
> 
> Signed-off-by: Timothy Nicholson <t.nicholson@proxmox.com>
> ---
> As stated in the Bugzilla entry [0]: Up until now, only two
> systemd states were translated. This patch changes this so all
> systemd states use gettext and are translated. For some of the
> states, translations need to be added.
> [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5836
> 
>  src/Utils.js            | 11 +++++++++++
>  src/node/ServiceView.js | 14 ++++++--------
>  2 files changed, 17 insertions(+), 8 deletions(-)
> 
> diff --git a/src/Utils.js b/src/Utils.js
> index 7dd034a..23b0db5 100644
> --- a/src/Utils.js
> +++ b/src/Utils.js
> @@ -305,6 +305,17 @@ utilities: {
>  	return Ext.htmlEncode(username);
>      },
>  
> +    renderSystemdStatus: function(status) {
> +	switch (status) {
> +	    case 'masked':
> +		return gettext('disabled');
> +	    case 'not-found':
> +		return gettext('not installed');
> +	    default:
> +		return gettext(status);

While the gettext function itself will gladly accept a string passed
in from a variable, the script extracting translatable strings [1] expects
a literal string that will be used as a reference for translations.

[1] https://git.proxmox.com/?p=proxmox-i18n.git;a=blob;f=jsgettext.pl;h=7f758fd9e5b3f5f7e0fb0c2ca0f46690df59dd58;hb=HEAD

-- 
- Lukas


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel