From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dietmar Maurer <dietmar@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] change tape drive lock path
Date: Mon, 12 Jul 2021 18:20:16 +0200 [thread overview]
Message-ID: <d540f23b-8e71-2aeb-1a5a-51904cd844de@proxmox.com> (raw)
In-Reply-To: <20210712152338.249178-1-dietmar@proxmox.com>
On 12.07.21 17:23, Dietmar Maurer wrote:
> New kernel has stricter checks on tmpfs with stick-bit on directories, so some
> commands (i.e. proxmox-tape changer status) fails when executed as root, because
> permission checks fails when locking the drive.
>
> This patch move the drive locks to /run/proxmox-backup/drive-lock.
>
> Note: This is incompatible to old locking mechmanism, so users may not
> run tape backups during update (or running backup can fail).
> ---
>
> Lock file permissions are still wrong if the user runs "proxmox-tape
> changer status" as root and the lock file does not exist already.
>
> src/bin/proxmox-backup-api.rs | 1 +
> src/tape/drive/mod.rs | 6 +++---
> src/tape/mod.rs | 18 ++++++++++++++++++
> 3 files changed, 22 insertions(+), 3 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-07-12 16:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 15:23 [pbs-devel] " Dietmar Maurer
2021-07-12 16:20 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d540f23b-8e71-2aeb-1a5a-51904cd844de@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.