all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH docs/widget-toolkit/manager v3] implement tagview
Date: Thu, 7 Nov 2024 15:20:59 +0100	[thread overview]
Message-ID: <d4f40ae2-f1f9-4b0b-86d6-0e94c0ac9dc4@proxmox.com> (raw)
In-Reply-To: <5993534d-9942-42a3-bd5f-1b512e646086@proxmox.com>



On  2024-11-07  15:16, Dominik Csapak wrote:
> On 11/7/24 14:52, Aaron Lauterer wrote:
>> gave this a quick test.
>>
>> two things I noticed:
>>
>> * root element in tree per tag: wouldn't it be better to override the 
>> display style to 'full'? Otherwise I might have a lot of colorful 
>> dots, but don't know what the tags are called.
> 
> that should be the case, but you need the widget toolkit patch installed 
> for that
> 

Ah okay, for some reason it didn't install in my test cluster. Yeah, 
looks good!

>>
>> * I am not 100% sure, but would it be possible to distinguish guests 
>> that have no tag assigned a bit better? maybe have a default "no-tags" 
>> tree for them?
> 
> mhmm. possibly, but i used the same style as we have in the 'pool view' 
> where guests/storages
> outside of pools are also just displayed one level higher
> 
>>
>> On  2024-11-07  12:25, Dominik Csapak wrote:
>>> this adds a 'tagview' to the web ui, organizing guests by their tags
>>> (for details see the pve-manager patch)
>>>
>>> I'm not super happy all in all with how much special casing must be
>>> done, but i could not (yet?) figure out a better way.
>>>
>>> changes from v2:
>>> * rebased on master (tooltip generation changed so adapted to that)
>>> * implemented fionas feedback, so selection should stay even when tags
>>>    are removed or the selection is changed from the tag view
>>>
>>> changes from v1:
>>> * rebase on master
>>> * adapt to recent tooltip changes
>>> * add a comment to TagConfig class to better explain what it does
>>>
>>> pve-docs:
>>>
>>> Dominik Csapak (1):
>>>    gui: add anchor for tags chapter
>>>
>>>   pve-gui.adoc | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> proxmox-widget-toolkit:
>>>
>>> Dominik Csapak (1):
>>>    css: add some conditions to the tag classes for the tag view
>>>
>>>   src/css/ext6-pmx.css | 22 +++++++++++++++-------
>>>   1 file changed, 15 insertions(+), 7 deletions(-)
>>>
>>> pve-manager:
>>>
>>> Dominik Csapak (1):
>>>    ui: implement 'Tag View' for the resource tree
>>>
>>>   www/manager6/Makefile             |  1 +
>>>   www/manager6/Workspace.js         |  4 +-
>>>   www/manager6/form/ViewSelector.js | 28 +++++++++++
>>>   www/manager6/grid/ResourceGrid.js |  2 +-
>>>   www/manager6/panel/TagConfig.js   |  6 +++
>>>   www/manager6/tree/ResourceTree.js | 81 ++++++++++++++++++++++++++++---
>>>   6 files changed, 113 insertions(+), 9 deletions(-)
>>>   create mode 100644 www/manager6/panel/TagConfig.js
>>>
>>
> 
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2024-11-07 14:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-07 11:25 Dominik Csapak
2024-11-07 11:25 ` [pve-devel] [PATCH docs v3 1/1] gui: add anchor for tags chapter Dominik Csapak
2024-11-07 11:25 ` [pve-devel] [PATCH widget-toolkit v3 1/1] css: add some conditions to the tag classes for the tag view Dominik Csapak
2024-11-07 11:25 ` [pve-devel] [PATCH manager v3 1/1] ui: implement 'Tag View' for the resource tree Dominik Csapak
2024-11-07 13:52 ` [pve-devel] [PATCH docs/widget-toolkit/manager v3] implement tagview Aaron Lauterer
2024-11-07 14:16   ` Dominik Csapak
2024-11-07 14:20     ` Aaron Lauterer [this message]
2024-11-08  9:44     ` Daniel Herzig
2024-11-10 11:22 ` [pve-devel] applied-series: " Thomas Lamprecht
2024-11-11 13:58   ` Dominik Csapak
2024-11-11 14:26     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4f40ae2-f1f9-4b0b-86d6-0e94c0ac9dc4@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal