all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] vzdump: pbs: suppress output from upload-log command
@ 2021-10-11  7:14 Fabian Ebner
  2021-10-11  7:51 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Ebner @ 2021-10-11  7:14 UTC (permalink / raw)
  To: pve-devel

which ended up in the backup task log and can be confusing to users:

> INFO: Backup finished at 2021-10-11 08:40:38
> Result: {
>       "data": null
> }
> INFO: Backup job finished successfully

For proxmox-backup-server < 2.0.11-1, there was no output for the
upload-log command.

Reported in the community forum:
https://forum.proxmox.com/threads/backup-finishes-ok-but-data-null-info-on-finish.97740/

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 PVE/VZDump.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index d00be8b2..88ac11b3 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -1097,6 +1097,7 @@ sub exec_backup_task {
 			'upload-log',
 			[ $pbs_snapshot_name, $task->{tmplog} ],
 			errmsg => "uploading backup task log failed",
+			outfunc => sub {},
 		    );
 		};
 		debugmsg('warn', "$@") if $@; # $@ contains already error prefix
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] vzdump: pbs: suppress output from upload-log command
  2021-10-11  7:14 [pve-devel] [PATCH manager] vzdump: pbs: suppress output from upload-log command Fabian Ebner
@ 2021-10-11  7:51 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-10-11  7:51 UTC (permalink / raw)
  To: Proxmox VE development discussion, Fabian Ebner

On 11.10.21 09:14, Fabian Ebner wrote:
> which ended up in the backup task log and can be confusing to users:
> 
>> INFO: Backup finished at 2021-10-11 08:40:38
>> Result: {
>>       "data": null
>> }
>> INFO: Backup job finished successfully
> 
> For proxmox-backup-server < 2.0.11-1, there was no output for the
> upload-log command.
> 
> Reported in the community forum:
> https://forum.proxmox.com/threads/backup-finishes-ok-but-data-null-info-on-finish.97740/
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  PVE/VZDump.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-11  7:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-11  7:14 [pve-devel] [PATCH manager] vzdump: pbs: suppress output from upload-log command Fabian Ebner
2021-10-11  7:51 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal