From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Daniel Tschlatscher <d.tschlatscher@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] Remove BackupFileDownloader.js file and Makefile entry
Date: Wed, 5 Oct 2022 19:36:53 +0200 [thread overview]
Message-ID: <d492ce23-e47a-13df-0275-671a6f44926f@proxmox.com> (raw)
In-Reply-To: <20220429144732.92823-1-d.tschlatscher@proxmox.com>
Am 29/04/2022 um 16:47 schrieb Daniel Tschlatscher:
> While finishing up my previous patch series I stumbled upon this file
> which is not referenced anywhere in the proxmox-backup repository nor
> in any of the other repositories as far as I can tell (except in the
> Makefile).
> I searched far and wide for any occurences and tested the backup
> explorer GUI without it, which still seems to work normally.
>
> Introduced in: 98425309b0106c9174505614525a9561d98c56d7
> References removed in: 3e395378bca5a844b2c820750cd57e4f2bfbacca
>
> Therefore I think this can be safely considered dead code and be
> removed. It shall remain in the pve-devel archives forevermore anyway.
>
> Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
> ---
> www/Makefile | 1 -
> www/window/BackupFileDownloader.js | 146 -----------------------------
> 2 files changed, 147 deletions(-)
> delete mode 100644 www/window/BackupFileDownloader.js
>
>
applied, thanks!
prev parent reply other threads:[~2022-10-05 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 14:47 [pbs-devel] " Daniel Tschlatscher
2022-10-05 17:36 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d492ce23-e47a-13df-0275-671a6f44926f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.tschlatscher@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.