all lists on lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server] resume: error out if VM is a template
@ 2025-02-18 11:03 Fabian Grünbichler
  2025-02-18 13:39 ` Fiona Ebner
  2025-02-18 14:03 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Fabian Grünbichler @ 2025-02-18 11:03 UTC (permalink / raw)
  To: pve-devel

template VMs might be started in prelaunch state when creating a backup, but
they must never be actually started fully, to avoid modifying their disks.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
 PVE/QemuServer.pm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index c1fbd468..b23b79e1 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -6403,6 +6403,9 @@ sub vm_resume {
 	    $conf = PVE::QemuConfig->load_config($vmid);
 	}
 
+	die "VM $vmid is a template and cannot be resumed!\n"
+	    if PVE::QemuConfig->is_template($conf);
+
 	if ($res->{status}) {
 	    return if $res->{status} eq 'running'; # job done, go home
 	    $resume_cmd = 'system_wakeup' if $res->{status} eq 'suspended';
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-18 14:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-18 11:03 [pve-devel] [PATCH qemu-server] resume: error out if VM is a template Fabian Grünbichler
2025-02-18 13:39 ` Fiona Ebner
2025-02-18 14:03 ` [pve-devel] applied: " Thomas Lamprecht

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal