Re: [pve-devel] [PATCH manager] fix: make 'ceph-volume' conditional on quincy install

[Aaron Lauterer <a.lauterer@proxmox.com>]

With pve-manager 7.2-6, installing pacific will fail very qickly, as the package 
'ceph-volume' cannot be found.

Tested this patch by installing pacific and quincy.

One comment inline

Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>

On 7/4/22 17:05, Stefan Sterz wrote:
> when installing non-quincy versions, 'ceph-volume' is not contained in
> the respective repositories and, thus, the install process would fail.
> 
> Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
> ---
> tested this by installing ceph pacific and quincy, but my setup wasn't
> really clean so i ran into some unrelated issues.
> 
>   PVE/CLI/pveceph.pm | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm
> index a85df130..8e6c8667 100755
> --- a/PVE/CLI/pveceph.pm
> +++ b/PVE/CLI/pveceph.pm
> @@ -176,13 +176,16 @@ __PACKAGE__->register_method ({
>   	my @ceph_packages = qw(
>   	    ceph
>   	    ceph-common
> -	    ceph-volume
>   	    ceph-mds
>   	    ceph-fuse
>   	    gdisk
>   	    nvme-cli
>   	);
>   
> +	if ($cephver eq 'quincy') {
Wouldn't it be better to check if we are not installing octopus & pacific? Then 
it will work for any newer Ceph version as well. Once we do not support octopus 
and pacific anymore, we can add 'ceph-volume' unconditionally to the list of 
packages to install.

> +	    push @ceph_packages, 'ceph-volume';
> +	}
> +
>   	print "start installation\n";
>   
>   	# this flag helps to determine when apt is actually done installing (vs. partial extracing)