From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] fix #4111: replication: don't send mail when fail count is zero
Date: Fri, 17 Jun 2022 17:20:18 +0200 [thread overview]
Message-ID: <d2fb3d66-5a6f-17aa-d2ac-2906e8d7bad1@proxmox.com> (raw)
In-Reply-To: <20220614094732.76236-1-f.ebner@proxmox.com>
Am 14/06/2022 um 11:47 schrieb Fabian Ebner:
> which can happen when failing to obtain the guest's migration lock.
> This led to a lot of mails being sent during migration (timeout for
> obtaining lock is only 2 seconds and we run it in a loop).
>
> One could argue that obtaining the lock should increase the fail
> count, but without the lock, the job state should not be touched and
> even the first three mails upon migration could be considered spam.
>
> Fixes: e6b8af20 ("replication: sent always mail for first three tries and move helper")
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/API2/Replication.pm | 4 ++++
> 1 file changed, 4 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2022-06-17 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 9:47 [pve-devel] " Fabian Ebner
2022-06-17 15:20 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2fb3d66-5a6f-17aa-d2ac-2906e8d7bad1@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.