Re: [PATCH proxmox-backup v3 03/10] ui: prune job: align prune edit window to other "Enable" checkboxes

[Christian Ebner <c.ebner@proxmox.com>]

On 10/9/26 4:53 PM, Jonas Theisen wrote:
> This commit aligns the already existing "Enabled" checkbox in
> the Prune Job Edit window to the other checkboxes.
> 
> Meaning a reword from "Enabled" to "Enable" as it is more common
> throghout the UI and the disabling of the schedule field if the

typo: s/throghout/throughout/

> checkbox is off.
> 
> Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
> ---
>   www/window/PruneJobEdit.js | 19 ++++++++++++++++++-
>   1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js
> index a3dafde21..2eb8c7129 100644
> --- a/www/window/PruneJobEdit.js
> +++ b/www/window/PruneJobEdit.js
> @@ -43,6 +43,15 @@ Ext.define('PBS.window.PruneJobEdit', {
>           },
>       },
>   
> +    setValues: function (values) {
> +        let me = this;
> +
> +        if (!values.schedule || values.schedule === '') {
> +            values.disable = true;
> +        }
> +        me.callParent([values]);
> +    },
> +
>       items: {
>           xtype: 'inputpanel',
>           onGetValues: function (values) {
> @@ -118,11 +127,19 @@ Ext.define('PBS.window.PruneJobEdit', {
>               },
>               {
>                   xtype: 'proxmoxcheckbox',
> -                fieldLabel: gettext('Enabled'),
> +                fieldLabel: gettext('Enable'),
>                   name: 'enable',
>                   uncheckedValue: 0,
>                   defaultValue: 1,
>                   checked: true,
> +                listeners: {
> +                    change: function (field, enabled) {
> +                        let me = this;
> +                        let view = me.up('pbsPruneJobEdit');
> +                        let schedule = view.down('field[name=schedule]');
> +                        schedule.setDisabled(!enabled);
> +                    },
> +                },

this hunk can be more concise by using ExtJS variable bindings:
```
diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js
index 2eb8c7129..5578dcf1f 100644
--- a/www/window/PruneJobEdit.js
+++ b/www/window/PruneJobEdit.js
@@ -43,6 +43,12 @@ Ext.define('PBS.window.PruneJobEdit', {
          },
      },

+    viewModel: {
+        data: {
+            jobEnabled: true,
+        },
+    },
+
      setValues: function (values) {
          let me = this;

@@ -124,6 +130,9 @@ Ext.define('PBS.window.PruneJobEdit', {
                  cbind: {
                      value: '{scheduleValue}',
                  },
+                bind: {
+                    disabled: '{!jobEnabled}',
+                },
              },
              {
                  xtype: 'proxmoxcheckbox',
@@ -131,14 +140,8 @@ Ext.define('PBS.window.PruneJobEdit', {
                  name: 'enable',
                  uncheckedValue: 0,
                  defaultValue: 1,
-                checked: true,
-                listeners: {
-                    change: function (field, enabled) {
-                        let me = this;
-                        let view = me.up('pbsPruneJobEdit');
-                        let schedule = view.down('field[name=schedule]');
-                        schedule.setDisabled(!enabled);
-                    },
+                bind: {
+                    value: '{jobEnabled}',
                  },
              },
          ],
```

>               },
>           ],
>