From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 2E1A11FF0BC for ; Thu, 15 Oct 2026 13:14:59 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D8BFE21434; Thu, 15 Oct 2026 13:14:58 +0200 (CEST) Message-ID: Date: Thu, 15 Oct 2026 13:14:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Christian Ebner Subject: Re: [PATCH proxmox-backup v3 03/10] ui: prune job: align prune edit window to other "Enable" checkboxes To: Jonas Theisen , pbs-devel@lists.proxmox.com References: <20261009145328.281554-1-j.theisen@proxmox.com> <20261009145328.281554-4-j.theisen@proxmox.com> Content-Language: en-US, de-DE In-Reply-To: <20261009145328.281554-4-j.theisen@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792062893155 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.506 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NK7UWXYHGSPVCX2NXXKSWYCDSLZBKYJT X-Message-ID-Hash: NK7UWXYHGSPVCX2NXXKSWYCDSLZBKYJT X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 10/9/26 4:53 PM, Jonas Theisen wrote: > This commit aligns the already existing "Enabled" checkbox in > the Prune Job Edit window to the other checkboxes. > > Meaning a reword from "Enabled" to "Enable" as it is more common > throghout the UI and the disabling of the schedule field if the typo: s/throghout/throughout/ > checkbox is off. > > Signed-off-by: Jonas Theisen > --- > www/window/PruneJobEdit.js | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js > index a3dafde21..2eb8c7129 100644 > --- a/www/window/PruneJobEdit.js > +++ b/www/window/PruneJobEdit.js > @@ -43,6 +43,15 @@ Ext.define('PBS.window.PruneJobEdit', { > }, > }, > > + setValues: function (values) { > + let me = this; > + > + if (!values.schedule || values.schedule === '') { > + values.disable = true; > + } > + me.callParent([values]); > + }, > + > items: { > xtype: 'inputpanel', > onGetValues: function (values) { > @@ -118,11 +127,19 @@ Ext.define('PBS.window.PruneJobEdit', { > }, > { > xtype: 'proxmoxcheckbox', > - fieldLabel: gettext('Enabled'), > + fieldLabel: gettext('Enable'), > name: 'enable', > uncheckedValue: 0, > defaultValue: 1, > checked: true, > + listeners: { > + change: function (field, enabled) { > + let me = this; > + let view = me.up('pbsPruneJobEdit'); > + let schedule = view.down('field[name=schedule]'); > + schedule.setDisabled(!enabled); > + }, > + }, this hunk can be more concise by using ExtJS variable bindings: ``` diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js index 2eb8c7129..5578dcf1f 100644 --- a/www/window/PruneJobEdit.js +++ b/www/window/PruneJobEdit.js @@ -43,6 +43,12 @@ Ext.define('PBS.window.PruneJobEdit', { }, }, + viewModel: { + data: { + jobEnabled: true, + }, + }, + setValues: function (values) { let me = this; @@ -124,6 +130,9 @@ Ext.define('PBS.window.PruneJobEdit', { cbind: { value: '{scheduleValue}', }, + bind: { + disabled: '{!jobEnabled}', + }, }, { xtype: 'proxmoxcheckbox', @@ -131,14 +140,8 @@ Ext.define('PBS.window.PruneJobEdit', { name: 'enable', uncheckedValue: 0, defaultValue: 1, - checked: true, - listeners: { - change: function (field, enabled) { - let me = this; - let view = me.up('pbsPruneJobEdit'); - let schedule = view.down('field[name=schedule]'); - schedule.setDisabled(!enabled); - }, + bind: { + value: '{jobEnabled}', }, }, ], ``` > }, > ], >