all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: fix zero-sized panels on fresh chrome start
Date: Mon, 20 Nov 2023 10:15:33 +0100	[thread overview]
Message-ID: <d1b6e937-682c-4df6-8d31-1e67bb7f8ccd@proxmox.com> (raw)
In-Reply-To: <20231120080242.443263-1-d.csapak@proxmox.com>

Am 20/11/2023 um 09:02 schrieb Dominik Csapak:
> it seems in new versions of chrome , this triggers too early on a fresh
> start (when autostarting a pve tab), resulting in the
> 'viewWidth'/'viewHeight' being zero pixels. This means we set the width
> of the left and the height of the bottom panel to zero pixels, making
> them functionally invisible.
> 
> To prevent that, check that the 'viewWidth'/'viewHeight' is big enough
> so that the panels still have least 50 pixels left before setting their
> size.
> 
> reported on the pve-user list:
> https://lists.proxmox.com/pipermail/pve-user/2023-November/017292.html
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> this plaged me for at least a week, but it seems no one else ran into
> this, so i blamed my local install, until the report on pve-user
> 
> we should probably backport this to stable-7, can send a separate fix
> should it not cleanly apply/be cherry-pickable
> 
>  www/manager6/Workspace.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, with the link swapped out to the one that's actually a report about
this issue in the forum, thanks!




      parent reply	other threads:[~2023-11-20  9:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-20  8:02 [pve-devel] " Dominik Csapak
2023-11-20  8:07 ` Dominik Csapak
2023-11-20  8:26   ` Thomas Lamprecht
2023-11-20  8:26     ` Dominik Csapak
2023-11-20  9:15 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1b6e937-682c-4df6-8d31-1e67bb7f8ccd@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal