all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Christian Ebner <c.ebner@proxmox.com>,
	Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager 5/7] ui: dashboard: distinguish failed remotes based on remote type
Date: Tue, 14 Oct 2025 11:24:18 +0200	[thread overview]
Message-ID: <d0f8392b-c6f6-4ec9-b5b8-d1a412087fca@proxmox.com> (raw)
In-Reply-To: <d992ac53-bbff-49fc-959a-751950262f57@proxmox.com>



On 10/14/25 11:19 AM, Christian Ebner wrote:
> On 10/14/25 10:47 AM, Dominik Csapak wrote:
>> more of a high level comment regarding the node dashboard component, but
>> it fits here as well as the previous patch:
>>
>> i believe we should rethink how we propagate the information
>> to this panel, so that we don't have to extract the correct information
>> inside
>>
>> e.g. either we restructure the api call/data in a way to separate
>> the info by type in the first place, or we do that directly
>> after the api call.
>>
>> either way I'd probably give this panel just a simple struct
>> with the necessary information to display
>>
>> I think this would make it a bit easier to follow and less
>> like that we forget to e.g. check the type for the content
>>
>> what do you say?
> 
> Yes, agreed. Will keep the panel input data as simple as possible then.
> 
> 
> Fetching the status by remote type would be an option, but at the cost 
> of an additional API call. Also the return data is already laid out to 
> be cumulative over remote type variants.

i'd like to avoid more api calls if possible/sensible

> 
> Therefore, maybe better to do the splitting of the remote type specific 
> information after getting the status?

sound good to me

> 
> Finally, splitting the `status` endpoint return data by type is nor 
> really an option, since that would be a breaking API change, so better 
> avoided.

since we're still in beta, this is not that much of a concern though

> 
> Thanks a lot for your comments!



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  reply	other threads:[~2025-10-14  9:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13  8:56 [pdm-devel] [PATCH datacenter-manager 0/7] add remote type based search and PBS node status panel to dashboard Christian Ebner
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 1/7] server: api: add remote-type search category for resources Christian Ebner
2025-10-14  8:35   ` Dominik Csapak
2025-10-14  9:01     ` Christian Ebner
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 2/7] pdm-api-types: extend resource status by list of failed remotes Christian Ebner
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 3/7] server: api: collect failed remotes list while getting status Christian Ebner
2025-10-14  8:37   ` Dominik Csapak
2025-10-14 12:41     ` Christian Ebner
2025-10-14 12:53       ` Dominik Csapak
2025-10-14 13:10         ` Christian Ebner
2025-10-14 13:17           ` Dominik Csapak
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 4/7] ui: dashboard: extend node panel creation by remote type Christian Ebner
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 5/7] ui: dashboard: distinguish failed remotes based on " Christian Ebner
2025-10-14  8:47   ` Dominik Csapak
2025-10-14  9:20     ` Christian Ebner
2025-10-14  9:24       ` Dominik Csapak [this message]
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 6/7] ui: dashboard: expose PBS nodes status panel Christian Ebner
2025-10-13  8:56 ` [pdm-devel] [PATCH datacenter-manager 7/7] ui: dashboard: filter by remote type for PVE and PBS node " Christian Ebner
2025-10-17 14:13 ` [pdm-devel] superseded: [PATCH datacenter-manager 0/7] add remote type based search and PBS node status panel to dashboard Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0f8392b-c6f6-4ec9-b5b8-d1a412087fca@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=c.ebner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal