Re: [PATCH backup v3 3/3] client: rename password to blob

[Christian Ebner <c.ebner@proxmox.com>]

On 2/23/26 10:37 AM, Maximiliano Sandoval wrote:
> This is a Vec<u8> and not yet the password in its final form.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>   pbs-client/src/tools/mod.rs | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/pbs-client/src/tools/mod.rs b/pbs-client/src/tools/mod.rs
> index f28d9f32f..aa3ae94f2 100644
> --- a/pbs-client/src/tools/mod.rs
> +++ b/pbs-client/src/tools/mod.rs
> @@ -167,8 +167,8 @@ fn get_secret_from_env(base_name: &str) -> Result<Option<String>, Error> {
>   fn get_secret_impl(env_variable: &str, credential_name: &str) -> Result<Option<String>, Error> {
>       if let Some(password) = get_secret_from_env(env_variable)? {
>           Ok(Some(password))
> -    } else if let Some(password) = get_credential(credential_name)? {
> -        str::from_utf8(&password)
> +    } else if let Some(blob) = get_credential(credential_name)? {
> +        str::from_utf8(&blob)
>               .map(|s| {
>                   if matches!(credential_name, CRED_PBS_REPOSITORY | CRED_PBS_FINGERPRINT) {
>                       s.trim_end()

since the conditional trimming is suggested to be done on the individual 
helpers (see comments on patch 1), this helper should also be renamed. 
E.g. it could be called get_secrets_blob() or raw_secret_as_string(), 
reflecting this.