From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pdm-devel] applied: [PATCH datacenter-manager] server/ui: don't return token secret in api response
Date: Thu, 19 Dec 2024 13:15:49 +0100 [thread overview]
Message-ID: <d0e459e3-3ba2-4e2b-a8d2-11ec1c6de77d@proxmox.com> (raw)
In-Reply-To: <20241219120341.2003443-1-d.csapak@proxmox.com>
Am 19.12.24 um 13:03 schrieb Dominik Csapak:
> as a stop-gap, simply return the empty string for the secret.
> Later we can fix that up with a proper type e.g. like we do in
> proxmox-backup with `RemoteWithoutPassword`, but that touches too many
> places here currently, so this seems fine for now.
>
> On the UI side it's enough to simply don't mark it required and
> add a placeholder. If its empty, it won't get submitted anyway.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> server/src/api/remotes.rs | 8 ++++++--
> ui/src/remotes/edit_remote.rs | 3 ++-
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
>
applied, thanks!
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2024-12-19 12:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 12:03 [pdm-devel] " Dominik Csapak
2024-12-19 12:15 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0e459e3-3ba2-4e2b-a8d2-11ec1c6de77d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal