[pbs-devel] applied-series: [PATCH proxmox-backup 0/8] improve datstore ux

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 27.10.20 16:20, Dominik Csapak wrote:
> this series aims to improve the datastore ux by
> * moving all datastore relevant settings/options/views into the
>   datastore tabpanel
> * adding a 'Summary' panel with some important information
> * improving tab selection between datastores/browser reloads/etc.
> 
> this needs my previous series: "improve and extend admin/datastore/status api"
> to work
> 
> some things are still to be improved, namely:
> * multiline comments for datastores
> * automatic ids for sync/verify jobs
> * improved prune/gc panel (e.g. with status of last run)
> * comments for backup snapshots
> 
> Dominik Csapak (8):
>   api/{verify,syncjobs}: add optional datastore parameter
>   ui: DataStoreContent: add 'Verify All' button
>   ui: add DataStorePruneAndGC panel and add it to datastore panel
>   ui: add DataStoreSummary and move Statistics into it
>   ui: move sync/verify jobs to the datastores
>   ui: NavigationTree: add 'Add Datastore' button below datastore list
>   ui: MainView/NavigationTree: improve tree selection handling
>   ui: DataStorePanel: save active tab statefully
> 
>  src/api2/admin/sync.rs        |  19 ++-
>  src/api2/admin/verify.rs      |  19 ++-
>  www/DataStoreContent.js       |  23 +++
>  www/DataStoreNotes.js         | 104 ++++++++++++
>  www/DataStorePanel.js         |  52 +++++-
>  www/DataStorePruneAndGC.js    | 164 +++++++++++++++++++
>  www/DataStoreStatistic.js     | 104 ------------
>  www/DataStoreSummary.js       | 296 ++++++++++++++++++++++++++++++++++
>  www/MainView.js               |  70 ++++----
>  www/Makefile                  |   5 +-
>  www/NavigationTree.js         | 101 ++++++++----
>  www/config/DataStoreConfig.js | 227 --------------------------
>  www/config/SyncView.js        |  14 +-
>  www/config/VerifyView.js      |  20 ++-
>  www/window/DataStoreEdit.js   | 147 +++++++++--------
>  www/window/SyncJobEdit.js     |   6 +-
>  www/window/VerifyJobEdit.js   |   6 +-
>  17 files changed, 898 insertions(+), 479 deletions(-)
>  create mode 100644 www/DataStoreNotes.js
>  create mode 100644 www/DataStorePruneAndGC.js
>  delete mode 100644 www/DataStoreStatistic.js
>  create mode 100644 www/DataStoreSummary.js
>  delete mode 100644 www/config/DataStoreConfig.js
> 



applied series, much thanks! FYI, pushed the following small patches on top:

ui: datastore summary: clarify that it's a deduplication factor
ui: datastore: used fixed-width icons for summary
ui: datastore: change GC/Prune title and buttons a bit
ui: datastore: add confirmation message to verify all


Some possible additions and thoughts:

* warning on summary if no GC, prune or verify job is configured (especially verify should
  be an warning-triangle, the other could be "notice-exclamation-mark" level)

* The "Removed Bytes" in the summary is a bit strange to me, I'd rather drop it

* make the backup count thing aligned like a table, with the Groups and Snapshots as column
  header, and maybe a "Total" row at the end with all summed up

* not sure where we'd put the only recently added "verify_new" datastore option, it could be
  possible to rename "Verify Jobs" to "Verification" and add a option panel over the jobs one,
  would only host that setting for now, though.

* onlineHelp buttons for all panels and their edit dialogs please (@Dylan, @Oguz, @all)