From: "Hannes Dürr" <h.duerr@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 qemu-server pve-storage 2/2] fix #1611: implement import of base-images for LVM-thin Storage
Date: Mon, 18 Dec 2023 13:02:33 +0100 [thread overview]
Message-ID: <d0d4f657-bd00-4b6a-a891-e87aed293bdb@proxmox.com> (raw)
In-Reply-To: <bc965cdd-4124-4d11-8d33-e9843cb9613b@proxmox.com>
On 12/14/23 15:23, Fiona Ebner wrote:
> create_base() will tell you the actual name, you should not override it
> with the old one. We expect it to match, but then there's no need for
> the assignment. If it doesn't match, you'd be returning something wrong.
> Or what am I missing?
If i am not mistaken there is the case:
Plugin current imagename action
lvmthin: base-100-disk-1 old_base =
LVMplug: -> vm-100-disk-1 not working due to collision
LVMplug: -> vm-100-disk-2 call find_free_disk()
lvmthin -> base-100-disk-2 != old_base
But I think we could also just skip this case and remove the
$oldbasename completly.
next prev parent reply other threads:[~2023-12-18 12:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 9:12 [pve-devel] [PATCH v2 qemu-server pve-storage 0/2] " Hannes Duerr
2023-12-07 9:12 ` [pve-devel] [PATCH v2 qemu-server pve-storage 1/2] migration: secure and use source volume names for cleanup Hannes Duerr
2023-12-14 13:58 ` Fiona Ebner
2023-12-07 9:12 ` [pve-devel] [PATCH v2 qemu-server pve-storage 2/2] fix #1611: implement import of base-images for LVM-thin Storage Hannes Duerr
2023-12-14 14:23 ` Fiona Ebner
2023-12-14 14:31 ` Fiona Ebner
2023-12-18 12:02 ` Hannes Dürr [this message]
2023-12-18 13:07 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0d4f657-bd00-4b6a-a891-e87aed293bdb@proxmox.com \
--to=h.duerr@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal