all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Daniel Kral <d.kral@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH container] fix #5907: ignore conflicting mount options for read-only mounts
Date: Thu, 28 Nov 2024 15:56:15 +0100	[thread overview]
Message-ID: <d0a6fcfa-ecb1-4d02-993e-1b750f354b21@proxmox.com> (raw)
In-Reply-To: <20241125130908.22076-1-f.schauer@proxmox.com>

On 11/25/24 14:09, Filip Schauer wrote:
> When mounting volumes as read-only, certain mount options like
> "discard", "lazytime", and "noatime" are either ignored or can cause the
> mount to fail. For example, attempting to mount with "-t zfs" and
> "-o ro,discard" leads to an error: filesystem cannot be mounted due to
> invalid option 'discard'.
> 
> This commit ensures that only valid mount options, such as "nodev",
> "noexec", and "nosuid", are applied to read-only mounts, avoiding
> potential mount failures.
> 
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>

I could reproduce the issue when backing up a container with at least 
one root disk or mountpoint, which has at least the mount option 
"discard" applied, and backing it up to a PBS instance (to stay close to 
the bug report I used v3.2.10-1 for this), while all images were stored 
on a ZFS pool.

After applying the patch, the container could be backed up to the same 
PBS instance without any trouble.

Reviewed-by: Daniel Kral <d.kral@proxmox.com>
Tested-by: Daniel Kral <d.kral@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2024-11-28 14:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25 13:09 Filip Schauer
2024-11-28 13:42 ` Fiona Ebner
2024-11-28 14:56 ` Daniel Kral [this message]
2025-02-11 10:17 ` Fiona Ebner
2025-02-11 12:17   ` Thomas Lamprecht
2025-02-11 12:15 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0a6fcfa-ecb1-4d02-993e-1b750f354b21@proxmox.com \
    --to=d.kral@proxmox.com \
    --cc=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal