Re: [pve-devel] [PATCH qemu-server/novnc/manager/docs v9 0/5] Feature VNC-Clipboard

[Markus Frank <m.frank@proxmox.com>]

ping

On 5/22/23 12:09, Markus Frank wrote:
> overall changes v9:
> * renamed vnc_clipboard to vnc-clipboard
> 
> 
> qemu-server:
> 
> changes v8:
> * removed unnecessary conditions
> * removed spicedevices variable and changed back to devices
> * created is_spice variable
> 
> changes v6:
> * added check if vga->type is set to prevent error when using default display
> * renamed clipboard to vnc_clipboard
> 
> changes v5:
> * removed return of regex check in the assertion-function for the clipboard config
> * moved clipboard code into spice-if-block
> 
> changes v4:
> * removed duplicate code and created a spicedevices variable to store
> spice/vdagent devices.
> * clipboard_check_compatibility function
> 
> changes v3:
> * added hint to make clearer that the spice guest tools are required for
>   the noVNC-clipboard
> * Checkbox changes to ComboBox when a spice device is selected to make
>   clear that only one clipboard can be used at a time.
> * added 2 test-cases
> 
> changes v2:
> * added pci address to virtio-serial-pci
> 
> Markus Frank (2):
>    enable clipboard parameter in vga_fmt
>    test cases for clipboard spice & std
> 
>   PVE/API2/Qemu.pm                          | 13 +++++
>   PVE/QemuServer.pm                         | 61 ++++++++++++++++-------
>   test/cfg2cmd/VNC-clipboard-spice.conf     |  1 +
>   test/cfg2cmd/VNC-clipboard-spice.conf.cmd | 27 ++++++++++
>   test/cfg2cmd/VNC-clipboard-std.conf       |  1 +
>   test/cfg2cmd/VNC-clipboard-std.conf.cmd   | 27 ++++++++++
>   6 files changed, 111 insertions(+), 19 deletions(-)
>   create mode 100644 test/cfg2cmd/VNC-clipboard-spice.conf
>   create mode 100644 test/cfg2cmd/VNC-clipboard-spice.conf.cmd
>   create mode 100644 test/cfg2cmd/VNC-clipboard-std.conf
>   create mode 100644 test/cfg2cmd/VNC-clipboard-std.conf.cmd
> 
> 
> novnc-pve:
> 
> Markus Frank (1):
>    added show clipboard button patch to series
> 
>   .../patches/0019-show-clipboard-button.patch  | 30 +++++++++++++++++++
>   debian/patches/series                         |  1 +
>   2 files changed, 31 insertions(+)
>   create mode 100644 debian/patches/0019-show-clipboard-button.patch
> 
> 
> pve-manager:
> 
> change v7:
> * fixed the empty Display Bug in VGA options found by Friedrich
>   (it should be "Default" instead of empty)
> 
> changes v6:
> * Changed onGetValues in DisplayEdit to only set the saved vnc_clipboard
> variable, so it's possible to reset type and memory to default values
> 
> changes v4:
> * moved clipboard option from Display settings in Hardware to Options
> 
> Markus Frank (1):
>    added clipboard checkbox to VM Options
> 
>   www/manager6/qemu/DisplayEdit.js |  8 +++++++
>   www/manager6/qemu/Options.js     | 37 ++++++++++++++++++++++++++++++++
>   2 files changed, 45 insertions(+)
> 
> 
> pve-docs:
> 
> changes v4:
> * rewrote entire Text
> * added command example to set clipboard to 1
> 
> Markus Frank (1):
>    added noVNC clipboard documentation
> 
>   qm.adoc | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
>