From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] applied: [PATCH v2 manager 1/2] api: Fix schema return annotation of tfa_update_auth
Date: Fri, 23 Jun 2023 08:02:35 +0200 [thread overview]
Message-ID: <cm5j465uouadkbq4tuaseav6hi2sipengerrbon7vuxtqt5y5a@dgygtqzsdpkz> (raw)
In-Reply-To: <20230620133908.250387-2-m.sandoval@proxmox.com>
applied this one
On Tue, Jun 20, 2023 at 03:39:07PM +0200, Maximiliano Sandoval wrote:
> In the next commit we expose a command to list the tfa methods of a
> user. Without this annotation one would get the following error
>
> unable to format result: got unexpected data (expected null).
>
> when running the proposed cli command.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> src/api2/access/tfa.rs | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/api2/access/tfa.rs b/src/api2/access/tfa.rs
> index 4b27c0db..89d7e353 100644
> --- a/src/api2/access/tfa.rs
> +++ b/src/api2/access/tfa.rs
> @@ -56,6 +56,11 @@ async fn tfa_update_auth(
> input: {
> properties: { userid: { type: Userid } },
> },
> + returns: {
> + description: "The list of TFA entries.",
> + type: Array,
> + items: { type: methods::TypedTfaInfo }
> + },
> access: {
> permission: &Permission::Or(&[
> &Permission::Privilege(&["access", "users"], PRIV_PERMISSIONS_MODIFY, false),
> --
> 2.39.2
next prev parent reply other threads:[~2023-06-23 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 13:39 [pbs-devel] [PATCH v2 manager 0/2] add user tfa {list, delete} commands Maximiliano Sandoval
2023-06-20 13:39 ` [pbs-devel] [PATCH v2 manager 1/2] api: Fix schema return annotation of tfa_update_auth Maximiliano Sandoval
2023-06-23 6:02 ` Wolfgang Bumiller [this message]
2023-06-20 13:39 ` [pbs-devel] [PATCH v2 manager 2/2] fix #4734: manager: add user tfa {list, delete} commands Maximiliano Sandoval
2023-06-23 6:04 ` Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cm5j465uouadkbq4tuaseav6hi2sipengerrbon7vuxtqt5y5a@dgygtqzsdpkz \
--to=w.bumiller@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.