From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH proxmox-widget-toolkit 2/2] disk list: disable show smart values button if status unknown
Date: Tue, 25 Feb 2025 17:41:34 +0100 [thread overview]
Message-ID: <cf62ef68-cc99-488f-ac3b-46824be88e32@proxmox.com> (raw)
In-Reply-To: <58d3277c-8ab7-4d2f-a8f8-23406acd2967@proxmox.com>
Am 25.02.25 um 17:22 schrieb Christian Ebner:
> Acked, will incorporate the suggestions for both patches in a v2, thanks
> for feedback!
btw before I forget it: This is some nice UX fine-polishing, but IMO the smart
status panel is not really ideal as main disk panel that opens on double click
and so on.
I'd rather transform this to open a generic disk, or partition, information
window showing things like model, serial, (part)uuid, in a main tab and make
that easily copyable. The smart data could be moved to a second tab in such
a window and only loaded when that opened. We could then mask its grid there
if the smart status is unknown or hide it completely if it cannot be queried,
like for partitions.
Some bigger changes but IMO quite a bit better UX than the status quo, which
feels rather confusing.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
WARNING: multiple messages have this Message-ID
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>,
pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [pve-devel] [PATCH proxmox-widget-toolkit 2/2] disk list: disable show smart values button if status unknown
Date: Tue, 25 Feb 2025 17:41:34 +0100 [thread overview]
Message-ID: <cf62ef68-cc99-488f-ac3b-46824be88e32@proxmox.com> (raw)
In-Reply-To: <58d3277c-8ab7-4d2f-a8f8-23406acd2967@proxmox.com>
Am 25.02.25 um 17:22 schrieb Christian Ebner:
> Acked, will incorporate the suggestions for both patches in a v2, thanks
> for feedback!
btw before I forget it: This is some nice UX fine-polishing, but IMO the smart
status panel is not really ideal as main disk panel that opens on double click
and so on.
I'd rather transform this to open a generic disk, or partition, information
window showing things like model, serial, (part)uuid, in a main tab and make
that easily copyable. The smart data could be moved to a second tab in such
a window and only loaded when that opened. We could then mask its grid there
if the smart status is unknown or hide it completely if it cannot be queried,
like for partitions.
Some bigger changes but IMO quite a bit better UX than the status quo, which
feels rather confusing.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-02-25 16:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-29 10:41 [pve-devel] [PATCH proxmox-widget-toolkit 1/2] panel: disk list: return consistent value for unknown smart status Christian Ebner
2024-11-29 10:41 ` [pbs-devel] " Christian Ebner
2024-11-29 10:41 ` [pve-devel] [PATCH proxmox-widget-toolkit 2/2] disk list: disable show smart values button if status unknown Christian Ebner
2024-11-29 10:41 ` [pbs-devel] " Christian Ebner
2025-02-25 16:19 ` [pve-devel] " Thomas Lamprecht
2025-02-25 16:19 ` [pbs-devel] " Thomas Lamprecht
2025-02-25 16:22 ` Christian Ebner
2025-02-25 16:22 ` [pbs-devel] " Christian Ebner
2025-02-25 16:41 ` Thomas Lamprecht [this message]
2025-02-25 16:41 ` Thomas Lamprecht
2025-02-25 16:17 ` [pve-devel] [PATCH proxmox-widget-toolkit 1/2] panel: disk list: return consistent value for unknown smart status Thomas Lamprecht
2025-02-25 16:17 ` [pbs-devel] " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf62ef68-cc99-488f-ac3b-46824be88e32@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.