From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Christoph Heiss <c.heiss@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH installer] proxmox-chroot: replace nix::(u)mount calls with external (u)mount
Date: Fri, 4 Apr 2025 13:37:59 +0200 [thread overview]
Message-ID: <ce5e7oau6kuxtvuk4fkexgxoigukfvnekqak6ljrrhm5ya272l@lpizedm7xcdd> (raw)
In-Reply-To: <20250311132733.820837-1-c.heiss@proxmox.com>
On Tue, Mar 11, 2025 at 02:27:29PM +0100, Christoph Heiss wrote:
> Comes with a reduction of 52 -> 40 in terms of crate dependencies for
> proxmox-chroot, 198 -> 192 for a full workspace build.
>
> Currently, this is done inconsistently anyway, i.e. there are calls to
> the external mount(8) as well as mount(2) and umount(2) via `nix`.
This makes sense in general. The `mount(2)` syscall is very raw and requires
knowledge of how a file system is to be mounted while additionally
adding a lot more features (especially when the new mount api is used
instead). The `mount(1)` call on the other hand calls out to various
file system specific helpers which provide a more user friendly
interface for various things. (Eg. you *can* definitely use `mount(2)` to
mount a ZFS, but you'd need to know the internals of how that works, and
it may change with zfs versions I think...)
Mounting is complicated in some cases ;-)
Unmounting on the other hand is rather simple and really just needs a
path... (the only sad part there is that there is no
path-file-descriptor based version)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-04-04 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-11 13:27 Christoph Heiss
2025-04-04 8:17 ` Thomas Lamprecht
2025-04-04 8:28 ` [pve-devel] applied: " Thomas Lamprecht
2025-04-04 8:39 ` Christoph Heiss
2025-04-04 11:37 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce5e7oau6kuxtvuk4fkexgxoigukfvnekqak6ljrrhm5ya272l@lpizedm7xcdd \
--to=w.bumiller@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.