From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage] cifs: use empty string instead of / as default directory
Date: Tue, 21 Mar 2023 12:39:41 +0100 [thread overview]
Message-ID: <cd71d738-8301-66d5-057f-f172b9cf7a99@proxmox.com> (raw)
In-Reply-To: <20230321111240.670720-1-s.ivanov@proxmox.com>
Am 21/03/2023 um 12:12 schrieb Stoiko Ivanov:
> this keeps the mount sources consistent with previous versions
> without this patch there is a small regression, which leads to the
> storage not being recognized as being mounted on upgrade:
> * pvestatd in older version mount the storage with out trailing /
> ```
> //cifsstore/ISO on /mnt/pve/cifsstore type cifs...
> ```
> * the cifs_is_mounted helper does not recognize it as being mounted
> (as the source now has a / in the end)
> * attempting to mount leads to
> ```
> mount error(16): Device or resource busy
> ```
>
> noticed after upgrading and having a cifs storage mounted
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> PVE/Storage/CIFSPlugin.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-03-21 11:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 11:12 [pve-devel] " Stoiko Ivanov
2023-03-21 11:39 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd71d738-8301-66d5-057f-f172b9cf7a99@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.