* [pve-devel] [PATCH cluster] ssh: default to 4096 bit keys when generating
@ 2023-12-21 9:46 Fabian Grünbichler
2024-03-22 16:35 ` Fiona Ebner
2024-03-25 7:46 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Fabian Grünbichler @ 2023-12-21 9:46 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
src/PVE/Cluster/Setup.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Cluster/Setup.pm b/src/PVE/Cluster/Setup.pm
index 07020d7..4b12bb8 100644
--- a/src/PVE/Cluster/Setup.pm
+++ b/src/PVE/Cluster/Setup.pm
@@ -157,7 +157,7 @@ sub setup_rootsshconfig {
# create ssh key if it does not exist
if (! -f $ssh_root_rsa_key_public) {
mkdir '/root/.ssh/';
- system ("echo|ssh-keygen -t rsa -N '' -b 2048 -f ${ssh_root_rsa_key_private}");
+ system ("echo|ssh-keygen -t rsa -N '' -b 4096 -f ${ssh_root_rsa_key_private}");
}
# create ssh config if it does not exist
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pve-devel] [PATCH cluster] ssh: default to 4096 bit keys when generating
2023-12-21 9:46 [pve-devel] [PATCH cluster] ssh: default to 4096 bit keys when generating Fabian Grünbichler
@ 2024-03-22 16:35 ` Fiona Ebner
2024-03-25 7:46 ` [pve-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Fiona Ebner @ 2024-03-22 16:35 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Grünbichler
Am 21.12.23 um 10:46 schrieb Fabian Grünbichler:
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
by removing my existing ones, attempt to SSH to other node and fail
(just to be sure), running pvecm updatecerts and SSH-ing to other node
with new key.
> ---
> src/PVE/Cluster/Setup.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/Cluster/Setup.pm b/src/PVE/Cluster/Setup.pm
> index 07020d7..4b12bb8 100644
> --- a/src/PVE/Cluster/Setup.pm
> +++ b/src/PVE/Cluster/Setup.pm
> @@ -157,7 +157,7 @@ sub setup_rootsshconfig {
> # create ssh key if it does not exist
> if (! -f $ssh_root_rsa_key_public) {
> mkdir '/root/.ssh/';
> - system ("echo|ssh-keygen -t rsa -N '' -b 2048 -f ${ssh_root_rsa_key_private}");
> + system ("echo|ssh-keygen -t rsa -N '' -b 4096 -f ${ssh_root_rsa_key_private}");
> }
>
> # create ssh config if it does not exist
^ permalink raw reply [flat|nested] 3+ messages in thread* [pve-devel] applied: Re: [PATCH cluster] ssh: default to 4096 bit keys when generating
2023-12-21 9:46 [pve-devel] [PATCH cluster] ssh: default to 4096 bit keys when generating Fabian Grünbichler
2024-03-22 16:35 ` Fiona Ebner
@ 2024-03-25 7:46 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2024-03-25 7:46 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Grünbichler
On 21/12/2023 10:46, Fabian Grünbichler wrote:
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> src/PVE/Cluster/Setup.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, (but was a bit to quick with the push before adding Fiona's R-b
& T-b, they are still much appreciated) thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-25 7:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-21 9:46 [pve-devel] [PATCH cluster] ssh: default to 4096 bit keys when generating Fabian Grünbichler
2024-03-22 16:35 ` Fiona Ebner
2024-03-25 7:46 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal