[pve-devel] [Allow snapshot backup with glusterfs 0/1]

[pve-devel] [Allow snapshot backup with glusterfs 0/1]

[Thomas Legay]

Thomas Legay (1):
  Allow LXC snapshot backup with glusterfs mount point

 src/PVE/LXC.pm | 1 +
 1 file changed, 1 insertion(+)

-- 
2.25.1

[pve-devel] [PATCH pve-container] Allow LXC snapshot backup with glusterfs mount point

[Thomas Legay]

Signed-off-by: Thomas Legay <thomas@lgy.fr>
---
 src/PVE/LXC.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index 9c150d9..5b54a85 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1114,6 +1114,7 @@ my $do_syncfs = sub {
 	proc => 1,
 	sysfs => 1,
 	tmpfs => 1,
+	'fuse.glusterfs' => 1,
     );
 
     # Now sync all mountpoints...
-- 
2.25.1

Re: [pve-devel] [Allow snapshot backup with glusterfs 0/1]

[Stoiko Ivanov]

Hi,

Thank you for contributing to PVE!

Could you explain what the patch fixes and why it works (would also be
great to have that information in the commit-message)?
I checked our bugzilla and the community forum, but could not find any
recent issue regarding gluster and containers (I probably overlooked it).

AFAICT the patch disables running syncfs(2) on the gluster fuse-mount used
for containers. Does the syncfs call fail? What error do you get?
The syncfs call is there to ensure that the backup is consistent as far as
possible - so I would not disable it without rationale.

On another note - we would need a signed CLA from you, in order to be able
to include your code in our codebase - see [0].

Best Regards,
stoiko

[0]
https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright

On Thu, 12 Nov 2020 19:48:38 +0100
Thomas Legay <thomas@lgy.fr> wrote:

> Thomas Legay (1):
>   Allow LXC snapshot backup with glusterfs mount point
> 
>  src/PVE/LXC.pm | 1 +
>  1 file changed, 1 insertion(+)
> 

Re: [pve-devel] [Allow snapshot backup with glusterfs 0/1]

[Thomas]

Hi
Thank for your review. 
When i backup lxc with glusterfs mount point, backup never finish.I
understant that you can disableit without rationale and maybe it's a
bad way to resolve this issue.I need to create ticket in bugzilla?
on function sync_container_namespace the bellow loop is never
exit.while (waitpid($child, 0) != $child) {}
There is no fail and no error message.
When i use bash command in lxc "sync /mount/point" there is no
issue.But
You can find bellow step to reproduce : 
---------------------------------------create lxc with name g1 with  -
debian 10 template  - on lvmthin pool storage - privilegied conteneur -
dhcp for configuration phase - exemple lxc id = 125
LXCG1=125LXCG2=126
pct start $LXCG1pct enter $LXCG1apt-get updateapt install glusterfs-
server -yapt cleansystemctl enable glusterd mkdir -p /data/glusterfs
#add the 2 line in /etc/hostscat << EOF >> /etc/hosts10.10.10.1
g1 10.10.10.2 g2 EOF
poweroff
pct clone $LXCG1 $LXCG2 --hostname g2pct set $LXCG1 --net0
name=eth0,bridge=vmbr0,ip=10.10.10.1/24pct set $LXCG2 --net0
name=eth0,bridge=vmbr0,ip=10.10.10.2/24pct set $LXCG1 --features
fuse=0,mknod=0
pct start $LXCG1pct start $LXCG2pct enter $LXCG1gluster peer probe
g2gluster volume create glusterfsvolume replica 2 g1:/data/glusterfs
g2:/data/glusterfs forcegluster volume start glusterfsvolume
mkdir /mnt/tmp/mount -t glusterfs g1:/glusterfsvolume /mnt/tmp
vzdump $LXCG2 #work

vzdump $LXCG1 #never finish------------------------------------------
---



Le vendredi 13 novembre 2020 à 15:12 +0100, Stoiko Ivanov a écrit :
> Hi,
> Thank you for contributing to PVE!
> Could you explain what the patch fixes and why it works (would also
> begreat to have that information in the commit-message)?I checked our
> bugzilla and the community forum, but could not find anyrecent issue
> regarding gluster and containers (I probably overlooked it).
> AFAICT the patch disables running syncfs(2) on the gluster fuse-mount 
> usedfor containers. Does the syncfs call fail? What error do you
> get?The syncfs call is there to ensure that the backup is consistent
> as far aspossible - so I would not disable it without rationale.
> On another note - we would need a signed CLA from you, in order to be
> ableto include your code in our codebase - see [0].
> Best Regards,stoiko
> [0]
> https://pve.proxmox.com/wiki/Developer_Documentation#Software_License_and_Copyright
> 
> On Thu, 12 Nov 2020 19:48:38 +0100Thomas Legay <thomas@lgy.fr> wrote:
> > Thomas Legay (1):  Allow LXC snapshot backup with glusterfs mount
> > point
> >  src/PVE/LXC.pm | 1 + 1 file changed, 1 insertion(+)