[pve-devel] [PATCH manager] GUI: disk reassign: remove unused reference and bind

[pve-devel] [PATCH manager] GUI: disk reassign: remove unused reference and bind

[Matthias Heiserer]

They are not used anywhere else, so I assume they were left over from
an earlier version.
Also, sometimes "[object object] flashes in the Target Guest field when
opening the reassign window, with this removed it doesn't occur.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
 www/manager6/window/GuestDiskReassign.js | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/www/manager6/window/GuestDiskReassign.js b/www/manager6/window/GuestDiskReassign.js
index 3795475d..f6d08b32 100644
--- a/www/manager6/window/GuestDiskReassign.js
+++ b/www/manager6/window/GuestDiskReassign.js
@@ -132,13 +132,9 @@ Ext.define('PVE.window.GuestDiskReassign', {
 	},
 	{
 	    xtype: 'vmComboSelector',
-	    reference: 'targetVMID',
 	    name: 'targetVmid',
 	    allowBlank: false,
 	    fieldLabel: gettext('Target Guest'),
-	    bind: {
-		value: '{targetVMID}',
-	    },
 	    store: {
 		model: 'PVEResources',
 		autoLoad: true,
-- 
2.30.2

Re: [pve-devel] [PATCH manager] GUI: disk reassign: remove unused reference and bind

[Aaron Lauterer]

thanks for catching this!

Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>

On 5/2/22 16:24, Matthias Heiserer wrote:
> They are not used anywhere else, so I assume they were left over from
> an earlier version.
> Also, sometimes "[object object] flashes in the Target Guest field when
> opening the reassign window, with this removed it doesn't occur.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>   www/manager6/window/GuestDiskReassign.js | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/www/manager6/window/GuestDiskReassign.js b/www/manager6/window/GuestDiskReassign.js
> index 3795475d..f6d08b32 100644
> --- a/www/manager6/window/GuestDiskReassign.js
> +++ b/www/manager6/window/GuestDiskReassign.js
> @@ -132,13 +132,9 @@ Ext.define('PVE.window.GuestDiskReassign', {
>   	},
>   	{
>   	    xtype: 'vmComboSelector',
> -	    reference: 'targetVMID',
>   	    name: 'targetVmid',
>   	    allowBlank: false,
>   	    fieldLabel: gettext('Target Guest'),
> -	    bind: {
> -		value: '{targetVMID}',
> -	    },
>   	    store: {
>   		model: 'PVEResources',
>   		autoLoad: true,

[pve-devel] applied: [PATCH manager] GUI: disk reassign: remove unused reference and bind

[Thomas Lamprecht]

Am 5/2/22 um 16:24 schrieb Matthias Heiserer:
> They are not used anywhere else, so I assume they were left over from
> an earlier version.
> Also, sometimes "[object object] flashes in the Target Guest field when
> opening the reassign window, with this removed it doesn't occur.
> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
>  www/manager6/window/GuestDiskReassign.js | 4 ----
>  1 file changed, 4 deletions(-)
> 
>

applied, thanks!