From: Friedrich Weber <f.weber@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH qemu-server] cloudinit: allow non-root users to set ciupgrade option
Date: Tue, 25 Jul 2023 15:55:38 +0200 [thread overview]
Message-ID: <cbffbca3-efdf-9134-753e-7650ad2f65b3@proxmox.com> (raw)
In-Reply-To: <bfba592b-6993-46b0-a4c0-3478638b900d@proxmox.com>
On 25/07/2023 11:54, Thomas Lamprecht wrote:
> How about a get_vm_user_cloudinit_options helper located directly
> below the format definition, filtering out those keys that do not
> make sense, or are off limits, and use that?
The helper sounds good! AFAICT, $cloudinitoptions contains exactly all
keys of $confdesc_cloudinit anyway -- so currently the helper could just
return a hash that maps all keys of $confdesc_cloudinit to 1. If it's
located close to the definition of $confdesc_cloudinit, I'd hope that it
makes adding new options in the future less error-prone (even for adding
a hypothetical option that should actually be modifiable by root only)
I'll look into it.
prev parent reply other threads:[~2023-07-25 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 11:33 [pve-devel] " Friedrich Weber
2023-07-25 9:54 ` [pve-devel] applied: " Thomas Lamprecht
2023-07-25 13:55 ` Friedrich Weber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbffbca3-efdf-9134-753e-7650ad2f65b3@proxmox.com \
--to=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.